[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Toby Thurston added the comment: Hey! thanks for letting me know, glad it got there in the end. T. On Fri, 13 Aug 2021, at 12:33, Łukasz Langa wrote: > > Łukasz Langa added the comment: > > Thanks for reporting and the initial patch, Toby. And thanks for > pushing this across the finish

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Łukasz Langa added the comment: Thanks for reporting and the initial patch, Toby. And thanks for pushing this across the finish line, Yussuf! ✨  ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.11 -Python 3.8

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Łukasz Langa added the comment: New changeset e4ed9d21534c2ed4397fdee0bb530a6e6a2c5af8 by dnknth in branch 'main': bpo-30077: Add support for Apple aifc/sowt pseudo-compression (GH-24449) https://github.com/python/cpython/commit/e4ed9d21534c2ed4397fdee0bb530a6e6a2c5af8 -- nosy:

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Yussuf Özkan added the comment: If you read a normal uncompressed AIFF with aifc, the samples are in big-endian order and need to be converted before they can be played on little-endian systems. As all other compression schemes produce big-endian data, so should 'SOWT' encoded AIFF.

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Change by Ned Deily : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Toby Thurston added the comment: I think it's probably better as a no-op. Currently in my patch I just put return data You could do return data[::-1] to reverse the sample, so that it came out as big endian, but if you leave it as a no-op then the data is returned in the native

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Xiang Zhang added the comment: Anyway, such a function addition could only get into 3.7. -- nosy: +xiang.zhang ___ Python tracker ___

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Serhiy Storchaka added the comment: Seems the "sowt" compression is not just a no-op operation. Perhaps it should change a byte order. Needed tests and test files for the new compression. -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka stage: -> patch review

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Changes by Xiang Zhang : -- components: +Library (Lib) -Extension Modules versions: +Python 3.7 -Python 3.6 ___ Python tracker ___

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

Changes by Toby Thurston : -- pull_requests: +1287 ___ Python tracker ___ ___

[issue30077] Support Apple AIFF-C pseudo compression in aifc.py

New submission from Toby Thurston: aifc.py fails to open AIFF files containing the compression type "sowt" in the COMM chunk with an "unsupported compression type" error. This compression type is an Apple specific extension that signals that the data is not actually compressed but is stored