[issue30603] textwrap: declining indent level has no test case

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 214f7eed7640f873223427c02a95a70775d2b396 by Mariatta (Jonathan 
Eunice) in branch 'master':
bpo-30603: add tests to textwrap.dedent (GH-2206)
https://github.com/python/cpython/commit/214f7eed7640f873223427c02a95a70775d2b396


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Emily Morehouse]

Emily Morehouse added the comment:

Looks great, thanks for the updates.

Mariatta, can you get this merged in?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Jonathan Eunice]

Jonathan Eunice added the comment:

@emilyemorehouse Added new tests per your request:

https://github.com/python/cpython/pull/2206

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Jonathan Eunice]

Changes by Jonathan Eunice :


--
pull_requests: +2250

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 601483d3b8a0433ca25f7fd6beea2cef674be039 by Mariatta (Jonathan 
Eunice) in branch 'master':
bpo-30603: Add test case to textwrap.dedent (GH-2014)
https://github.com/python/cpython/commit/601483d3b8a0433ca25f7fd6beea2cef674be039


--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Emily Morehouse]

Emily Morehouse added the comment:

Good catch. We should also add additional tests for a declining indentation 
level with a blank line and a declining indentation with a whitespace only 
line, as it is a pattern followed throughout the dedent tests. 

It should be noted that PR 2014 is the appropriate pull request for this issue. 
PR 2064 is for a different, though related, issue 
(https://bugs.python.org/issue30620).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
assignee:  -> emilyemorehouse
nosy: +emilyemorehouse

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Jonathan Eunice]

Changes by Jonathan Eunice :


--
pull_requests: +2128

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Jonathan Eunice]

Changes by Jonathan Eunice :


--
pull_requests: +2079

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30603] textwrap: declining indent level has no test case

[Jonathan Eunice]

New submission from Jonathan Eunice:

The case where textwrap.dedent() handles a declining indent level, requiring it 
to revise its margin estimate downward, remains untested.

This issue is opened in support of an imminent PR that adds an appropriate test.

--
components: Library (Lib)
messages: 295464
nosy: jonathaneunice
priority: normal
severity: normal
status: open
title: textwrap: declining indent level has no test case
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com