[issue30654] signal module always overwrites SIGINT on interpreter shutdown

STINNER Victor added the comment: I marked bpo-24415 as duplicate of this issue. -- ___ Python tracker ___ ___ Python-bugs-list

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: So this is in 2.7 finally. Closing again. -- stage: patch review -> resolved status: open -> closed versions: +Python 2.7 ___ Python tracker

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: New changeset ded666ff0ce44785a495ff89b676ca68e4cc08e8 by Antoine Pitrou in branch '2.7': [2.7] bpo-30654: Do not reset SIGINT handler to SIG_DFL in finisignal (GH-7146) (GH-7347)

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Change by Antoine Pitrou : -- pull_requests: +6973 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: Reopening for the 2.7 backport discussion. -- status: closed -> open ___ Python tracker ___ ___

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

STINNER Victor added the comment: IMHO it's a bugfix. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: Short of any bug in the patch, yes, it's stricly an improvement. -- ___ Python tracker ___ ___

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Benjamin Peterson added the comment: It seems like this only affects embeddings and for embeddings, it's strictly an improvement? -- ___ Python tracker ___

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: I'm nosy'ing Benjamin, the 2.7 release manager, in case he wants to comment on desirability of this bugfix in Python 2.7. -- nosy: +benjamin.peterson ___ Python tracker

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

pkerling <9b6ab...@casix.org> added the comment: Thanks! I'm a bit disappointed that it won't make it into 2.7, but I can understand the decision. To give some context: I came across this while working on Kodi and noticing that it does not shutdown cleanly via Ctrl+C or SIGTERM. After

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

STINNER Victor added the comment: Thanks pkerling for your bug report and your fix! -- ___ Python tracker ___ ___ Python-bugs-list

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: New changeset 1d5198fd41ad9185e9e6b3aa595769c3693d57be by Antoine Pitrou (Miss Islington (bot)) in branch '3.6': bpo-30654: Do not reset SIGINT handler to SIG_DFL in finisignal (GH-7146) (GH-7307)

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: New changeset 623b439abebc913bc416d92f38fe371e84b0276b by Antoine Pitrou (Miss Islington (bot)) in branch '3.7': bpo-30654: Do not reset SIGINT handler to SIG_DFL in finisignal (GH-7146) (GH-7306)

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: Ok, I think it go into 3.7.0 after all. 3.7.1 wouldn't get more testing before it's released anyway. -- ___ Python tracker ___

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Ned Deily added the comment: > What's the procedure here? If I backport the fix to the 3.7 branch, will it > go straight into the 3.7.0 release or will it be deferred to 3.7.1?? "All fixes that have been merged into the 3.7 branch as of cutoff tomorrow will be in 3.7.0b5 and fixes merged

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

STINNER Victor added the comment: > You have it backwards. Please read the bug report. I'm confused by the NEWS entry: +Fixed reset of the SIGINT handler to SIG_DFL on interpreter shutdown even +when there was a custom handler set previously. Patch by Philipp Kerling. I read it as Python

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: > For 3.7, we are very close to the final release. It doesn't give much time to > users to test the new behavior That's a fair point. What's the procedure here? If I backport the fix to the 3.7 branch, will it go straight into the 3.7.0 release or will

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: > So if an application has its own signal handler, Python replaces it... You have it backwards. Please read the bug report. -- ___ Python tracker

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

STINNER Victor added the comment: > I'd rather not backport this to 2.7 as it's quite late in the maintenance > cycle and I'd like to avoid any regressions there. Since it's a subtle behavior change and the PR doesn't add a flag to opt-in for the old behaviour, I'm not sure about

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: I'd rather not backport this to 2.7 as it's quite late in the maintenance cycle and I'd like to avoid any regressions there. -- ___ Python tracker

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Change by Antoine Pitrou : -- versions: +Python 3.8 -Python 2.7, Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Change by miss-islington : -- pull_requests: +6939 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Change by miss-islington : -- pull_requests: +6938 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Antoine Pitrou added the comment: New changeset e905c84494526363086f66a979e317e155bf9536 by Antoine Pitrou (pkerling) in branch 'master': bpo-30654: Do not reset SIGINT handler to SIG_DFL in finisignal (GH-7146)

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Change by pkerling <9b6ab...@casix.org>: -- keywords: +patch pull_requests: +6780 stage: -> patch review ___ Python tracker ___

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Changes by STINNER Victor : -- nosy: +haypo, pitrou ___ Python tracker ___ ___

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Changes by STINNER Victor : -- versions: -Python 3.3, Python 3.4 ___ Python tracker ___

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

Changes by Roundup Robot : -- pull_requests: +2213 ___ Python tracker ___

[issue30654] signal module always overwrites SIGINT on interpreter shutdown

New submission from pkerling: The signal module checks the SIGINT handler on startup. It only registers a new custom handler if the default OS handler is still installed, so that when embedding python in an application the SIGINT handler of that application is not overwritten. But on