[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

Change by STINNER Victor : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

STINNER Victor added the comment: The commit 6c2feabc5dac2f3049b15134669e9ad5af573193 of bpo-31217 fixed a major random bug in the memory block check. So maybe we can start again to look to detect more bugs by replacing all() with any() again. -- __

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

STINNER Victor added the comment: > Except that now it may hide actual regressions... False negatives are not > better than false positives. Please put this issue in its context. 6 months ago, there was no more Refleak buildbot and everything was broken. If you want to make regrtest -R strice

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

Antoine Pitrou added the comment: > Since I rejected "false alarms" from refleak, the refleak buildbot already > helped to identify a reference leak regression. Except that now it may hide actual regressions... False negatives are not better than false positives. -- _

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

STINNER Victor added the comment: Antoine Pitrou: "Victor, it would be nice if you could find a less brutal heuristic." My current goal is to get green buildbots. If a buildbot is always red, it's hard to notify easily regressions. Since I rejected "false alarms" from refleak, the refleak bui

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

Antoine Pitrou added the comment: This change suddenly made detection of reference leaks a lot less effective. Now if you have a single 0 in the deltas list, it will consider there is no reference leak, even though all other values might be > 0. See https://bugs.python.org/issue31317#msg30106

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

STINNER Victor added the comment: New changeset 0b1210739d12c26e4a161ffd494bd572d49b2483 by Victor Stinner in branch '3.5': [3.5] bpo-29512, bpo-30764, bpo-30776: Backport regrtest enhancements from 3.6 to 3.5 (#2540) https://github.com/python/cpython/commit/0b1210739d12c26e4a161ffd494bd572d49

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

Changes by STINNER Victor : -- pull_requests: +2608 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

STINNER Victor added the comment: New changeset a3ca94d0504157a112a1f89bfe8be1307116fc73 by Victor Stinner in branch '3.6': [3.6] bpo-29512, bpo-30776: Backport regrtest enhancements from master to 3.6 (#2513) https://github.com/python/cpython/commit/a3ca94d0504157a112a1f89bfe8be1307116fc73

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

Changes by STINNER Victor : -- pull_requests: +2583 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

STINNER Victor added the comment: New changeset beeca6e1e5fd01531b1db7059498b13d07dca525 by Victor Stinner in branch 'master': bpo-30776: regrtest: reduce memleak false positive (#2484) https://github.com/python/cpython/commit/beeca6e1e5fd01531b1db7059498b13d07dca525 -- _

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

Changes by STINNER Victor : -- pull_requests: +2543 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30776] regrtest: change -R/--huntrleaks rule to decide if a test leaks references

STINNER Victor added the comment: It seems like the change works well since I didn't see any more false alarms on the Refleaks buildbots. I close the issue. The change has been applied to 2.7, 3.5, 3.6 and master branches. -- resolution: -> fixed stage: -> resolved status: open -> cl