[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset a8de6964ec46cdadb12cf2d45ebf1473659c by Terry Jan Reedy (Miss 
Islington (bot)) in branch '3.6':
bpo-30781: Remove unused imports in idlelib.configdialog. (GH-4627) (#4630)
https://github.com/python/cpython/commit/a8de6964ec46cdadb12cf2d45ebf1473659c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4545

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset e8f7c78a868834bb53fa0ac903fc87785112f49e by Terry Jan Reedy in 
branch 'master':
bpo-30781: Remove unused imports in idlelib.configdialog. (#4627)
https://github.com/python/cpython/commit/e8f7c78a868834bb53fa0ac903fc87785112f49e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +4542

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:

I moved PR3215 to #27755.  So this issue is really closed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 4a8b53a2083506ee13ff2eba2c14264f5a7faa91 by Terry Jan Reedy (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-30781: IDLE: Fix help button on configdialog (GH-3238) (#3489)
https://github.com/python/cpython/commit/4a8b53a2083506ee13ff2eba2c14264f5a7faa91


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3481

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 3866d9bbcf808cea98b3d7f9f246b83858ce by Terry Jan Reedy 
(Cheryl Sabella) in branch 'master':
bpo-30781: IDLE: Fix help button on configdialog (#3238)
https://github.com/python/cpython/commit/3866d9bbcf808cea98b3d7f9f246b83858ce


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +3280

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +3254

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:

Main effects on Windows:
* Label in LabelFrame is blue.
* Widget frames turn blue when target by mouse.  (This is especially nice for 
checkbuttons, where the visible 'frame' is the circle, while the mouse just 
needs to be inside the invisible actual frame that includes the circle and 
label.)
* Button flat (I know that we could restore 'old-fashioned' relief with 
explicit styles) and sometimes larger.
Font sample left-justified instead of centered.  No necessarily bad.

Overall, a slight improvement even on Windows.  We can tweak details when 
revising individual pages.

The dynamic option menus look out of place, and should be replaced.

--
dependencies:  -IDLE: configdialog - add tests for ConfigDialog GUI.
resolution:  -> fixed
stage: test needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 7b556025ff7d663233e7fcb84785eb071f5e2ba7 by Terry Jan Reedy in 
branch '3.6':
[3.6] bpo-30781: IDLE -  use ttk widgets in configdialog (GH-2654) (#3214)
https://github.com/python/cpython/commit/7b556025ff7d663233e7fcb84785eb071f5e2ba7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +3252

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 7028e5986fceeeb73dffb5d5bf8f03d88f73b63d by Terry Jan Reedy 
(Cheryl Sabella) in branch 'master':
bpo-30781: IDLE -  use ttk widgets in configdialog (#2654)
https://github.com/python/cpython/commit/7028e5986fceeeb73dffb5d5bf8f03d88f73b63d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Cheryl Sabella]

Cheryl Sabella added the comment:

I rebased my PR and updated the tests so that they would pass.  I knew 'bg' on 
the frame would be changed, but I was surprised by the 'state' changes.  
'normal' only exists for compatibility and isn't one of the states to check in 
the tests; instead, 'disabled' and '!disabled' set the state and either 
'disabled' appears in the tuple or it doesn't appear.  I suppose I could have 
changed the tests to be assertNotIn.

https://docs.python.org/3/library/tkinter.ttk.html#widget-states

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:

I fixed the test problem by selecting the General page in the class setup with 
d.note.select(3).  Then the focus_force to a widget on the page must have 
worked.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:

I will check for anything even vaguely related.  In any case, your comment 
reminded me to give your PR a boost.  Too bad it will miss 3.5.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Cheryl Sabella]

Cheryl Sabella added the comment:

I wonder if the usability bug is related to issue25684, even though it's a 
different widget.  The reason I'm suggesting that is that I had converted the 
DynOptionMenu to be a ttk.OptionMenu in configdialog, but when I did that, that 
selection of a target tag on the highlight screen and the clicking of a target 
within highlight_sample didn't stay in sync, and that sounds very much like 
what it happening in helplist.

My patch for 25684 fixed the reported issue, but also fixed what I was seeing 
in configdialog.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 8364feff6730f54063116b607605167d9027ce85 by Terry Jan Reedy in 
branch '3.6':
[3.6] bpo-30781: IDLE - Use ttk Notebook in ConfigDialog (GH-2938) (#2944)
https://github.com/python/cpython/commit/8364feff6730f54063116b607605167d9027ce85


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:

The 'this' in 'this is a usability bug' refers to the fact that up and down 
move the blue selection highlight but not the selection, so that delete does 
not necessarily delete what appears to be selected.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +2993

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset b331f80b4765c3201674a7ca8b35c9d4a65efe79 by Terry Jan Reedy in 
branch 'master':
bpo-30781: IDLE - Use ttk Notebook in ConfigDialog (#2938)
https://github.com/python/cpython/commit/b331f80b4765c3201674a7ca8b35c9d4a65efe79


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:

I did not try to match the height in that commit.  I wanted to see what would 
happen if we enlarge the dialog to accommodate more widgets.  It is now about 
10% larger.  The highlight sample looks better with a bit more room.  The font 
sample works better in that the box does not expand until it has to.  The total 
size does not change.

Focus traversal has been neglected on C.D., which is a bit of a bug.  On the 
original, the focus disappears and comes back.  On the notebook it visibly 
cycles around one tab, including the tab.  I changed takefocus to True for 
fontlist and helplist.

When focus is on a tab, Left and Right change tabs.  With the enable call, 
Cntl_Tab and Cntl-Shift-Tab always work to change tabs.

I decided to push this in spite of the test problem.  It is easy to check that 
helplist clicking work on htest.  Maybe fixing up and down on helplist, as done 
with fontlist, will somehow help.  This is a usability bug, not a test bug. I 
should make the boxes identical before giving up.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Cheryl Sabella]

Cheryl Sabella added the comment:

Looks good under Ubuntu.  The height of the window is longer, so everything is 
a bit stretched out.  That helps on the Keys tab, but not so much on Highlights 
or Extensions.  It's not awful, but there's unneeded (for now?) empty space.

One thing that's different is that there is an initial focus selected on each 
tab when switching tabs, but then focus is lost when moving back to another 
tab.  

Example: When the config dialog is opened, focus is on the fonts, like it was 
after Louie's change.  However, when I first click 'Keys', there is a box 
around 'Use a Built-in Key Set', even if it isn't selected. So, that's new 
(there was no focus before).  When I then click back to 'Fonts', the fontlist 
doesn't have focus anymore.  Before this change, fontlist still had focus after 
switching to another tab and then going back to fonts.  Might be why the test 
isn't working.

All the tests pass, but I get the error if I uncomment the helplist tests:
==
FAIL: test_source_selected (idlelib.idle_test.test_configdialog.GeneralTest)
--
Traceback (most recent call last):
  File "/home/cheryl/cpython/Lib/idlelib/idle_test/test_configdialog.py", line 
315, in test_source_selected
self.assertEqual(helplist.get('anchor'), 'source')
AssertionError: '' != 'source'
+ source

--

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Terry J. Reedy added the comment:

New PR replaces the custom TabbedPageSet with ttk.Notebook.  On Windows, with 
default settings, the look is nearly identical, but the selected tab is more 
obvious.  A method call (note.enable_traversal) will enable navigation between 
tabs with cntl-tab and cntl-shift-tab.  This will work a bit better with 
extracted page classes.

On the otherhand, attaching the frame to a notebook instead of the one disables 
one of the simulated mouse clicks.  I added the remaining part of 
tkinter.test.support.simulate_click(sp??) to no avail (not surprising since 
designed for Xwindows.  I also moved the location of the simulated click.  
Using ttk.Frame requires the padx, pady to padding change in PR2654.

Please test on linuxes (and mac if possible).  Does the tabset look at least as 
good?  Does the test run if the #s are removed?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +2990

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +2719

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
dependencies: +IDLE: configdialog - add tests for ConfigDialog GUI.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30781] IDLE: configdialog -- switch to ttk widgets.

[Terry J. Reedy]

New submission from Terry J. Reedy:

Change imports and see what else needs fixing.
#27755 is one specific ttk switch that could be done before, as part of, or 
after this.

This issue depends on #30780 test GUI

--
assignee: terry.reedy
components: IDLE
messages: 296964
nosy: terry.reedy
priority: normal
severity: normal
stage: test needed
status: open
title: IDLE: configdialog -- switch to ttk widgets.
type: enhancement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com