[issue30809] IDLE parenmatch - highlighting options

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I agree.  The parenmatch highlighting is so transient that it hardly matters 
what it is, except that it should not match a syntax color.

--
dependencies:  -Idle extension configuration: add option-help option
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Tal Einat]

Tal Einat  added the comment:

FWIW I'm -1 on this change, due to the decision to keep IDLE simple for new 
users learning Python rather than power users.

--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Charles Wohlganger]

Changes by Charles Wohlganger :


--
pull_requests:  -2554

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Charles Wohlganger]

Changes by Charles Wohlganger :


--
keywords: +patch
pull_requests: +3565
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Terry J. Reedy]

Terry J. Reedy added the comment:

As I said on #27099, please do not include new options with the transfer patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Charles Wohlganger]

Charles Wohlganger added the comment:

I've rolled pretty much all this was going to do, other than underlining and 
font work into #27099. Trying to bring parenmatch into main otherwise would 
have been just as much of a hassle.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Terry J. Reedy]

Terry J. Reedy added the comment:

Since configdialog code is being re-written, I would not want to write code 
right now.  But we could start planning.

--
dependencies: +IDLE: turn builting extensions into regular modules

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Charles Wohlganger]

Charles Wohlganger added the comment:

Implimenting #27099 seems the more reasonable solution to me, so I'll work on 
that when I have free time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Terry J. Reedy]

Terry J. Reedy added the comment:

There is another option.  I want to incorporate 'builtin extensions' as regular 
features (#27099), and move their configuration options to other tabs, which 
will need some reworking.  #22705 will then be less urgent. Selection from a 
finite set will then be from a dropdown box, like similar non-extension 
options. Thus #27099, which waiting on current work in process on ConfigDialog, 
is an alternate dependency.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Terry J. Reedy]

Terry J. Reedy added the comment:

As far as you want to go with
1. Review the uploaded patch here or on Rietveld (see review link).
   Or skip this if you make PR and review on github.
2. Download code, makes minimal changes needed to succeed with 'git apply 
download' in new branch.
3. git commit -m "Patch by Saimadhav Heblikar updated to 3.7"
4. (Optional) test, make changes needed to pass, commit.
5. Make PR and comment or review on github.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Charles Wohlganger]

Charles Wohlganger added the comment:

The pull request has been changed to only have the theme element able to be 
selected. #22705 hasn't had activity in a few years. Is there something I can 
do to move it along?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Terry J. Reedy]

Terry J. Reedy added the comment:

I am not willing to add a new theme element to the 13 that already exist, let 
alone define it in config-extensions.def rather than in config-hightlight.def.  
It is too much additional complication for too little impact.  Also, any theme 
specified in config-extensions would likely not work if the user switches 
between dark and light text.  Theme sets work together.

I will consider letting users select which of the existing 13 to use.  This 
requires that users be able to know what the 13 choices are.  Hence  the 
dependence on #22705.

I might also look at the visual effect of underlining.

--
dependencies: +Idle extension configuration: add option-help option
priority: normal -> low
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Charles Wohlganger]

Changes by Charles Wohlganger :


--
pull_requests: +2554

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30809] IDLE parenmatch - highlighting options

[Charles Wohlganger]

New submission from Charles Wohlganger:

Current IDLE parenmatch highlighting uses the 'hilite' style when highlighting 
the parens/expression.

Desired behavior is to use a user-setting based style that is independent from 
the hilite style (which is used for highlighting selected text). Desired 
selectable options are for foreground color, background color, underlining and 
font (which covers font type, size, bold, and italics)

Apart from running IDLE and checking that the selections match, I don't know 
how to test. Testing would need a human to check for correct colors, etc. if it 
was made, so it couldn't be automated...

--
assignee: terry.reedy
components: IDLE
messages: 297317
nosy: terry.reedy, wohlganger
priority: normal
severity: normal
status: open
title: IDLE parenmatch - highlighting options
type: enhancement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com