[issue30993] IDLE: Document, fix, and complete configdialog font tests

2017-07-24 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30993] IDLE: Document, fix, and complete configdialog font tests

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 1daeb259799d0664c9453a3bd8e80411e65b52c9 by Terry Jan Reedy in branch '3.6': [3.6] bpo-30993: IDLE - Improve configdialog font page and tests. (GH-2831) (#2834) https://github.com/python/cpython/commit/1daeb259799d0664c9453a3bd8e80411e65b52c9

[issue30993] IDLE: Document, fix, and complete configdialog font tests

2017-07-23 Thread Ned Deily
Changes by Ned Deily : -- nosy: +ned.deily ___ Python tracker ___ ___ Python-bugs-list

[issue30993] IDLE: Document, fix, and complete configdialog font tests

2017-07-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ned, in a comment on PR2826, Louie reported "The patch unittest work on Linux, but on MacOS, I get test.support.ResourceDeined: cannot run without OS X gui process, it is wierd, I'm inside the GUI mode. Also, I'm not sure if this only on MacOS (is font

[issue30993] IDLE: Document, fix, and complete configdialog font tests

2017-07-23 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2881 ___ Python tracker ___ ___

[issue30993] IDLE: Document, fix, and complete configdialog font tests

2017-07-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 77e97ca9ff6f3dbbf98b89b4103c46b43eef5642 by Terry Jan Reedy in branch 'master': bpo-30993: IDLE - Improve configdialog font page and tests. (#2831) https://github.com/python/cpython/commit/77e97ca9ff6f3dbbf98b89b4103c46b43eef5642 --

[issue30993] IDLE: Document, fix, and complete configdialog font tests

2017-07-23 Thread Cheryl Sabella
Cheryl Sabella added the comment: The tests pass on linux and the htest looks good. Thank you for making all these changes. It seems much clearer now, but I do want to spend more time reading the code to understand it. Looks like you grouped all the font-related functions, so they are

[issue30993] IDLE: Document, fix, and complete configdialog font tests

2017-07-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: 2nd and presumably last PR for this issue: please verify on linux. -- stage: needs patch -> patch review title: IDLE: Document and fix configdialog font tests. -> IDLE: Document, fix, and complete configdialog font tests