[issue30993] IDLE: Document, fix, and complete configdialog font tests

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30993] IDLE: Document, fix, and complete configdialog font tests

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 1daeb259799d0664c9453a3bd8e80411e65b52c9 by Terry Jan Reedy in 
branch '3.6':
[3.6] bpo-30993: IDLE - Improve configdialog font page and tests. (GH-2831) 
(#2834)
https://github.com/python/cpython/commit/1daeb259799d0664c9453a3bd8e80411e65b52c9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30993] IDLE: Document, fix, and complete configdialog font tests

[Ned Deily]

Changes by Ned Deily :


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30993] IDLE: Document, fix, and complete configdialog font tests

[Terry J. Reedy]

Terry J. Reedy added the comment:

Ned, in a comment on PR2826, Louie reported "The patch unittest work on Linux, 
but on MacOS, I get test.support.ResourceDeined: cannot run without OS X gui 
process, it is wierd, I'm inside the GUI mode.

Also, I'm not sure if this only on MacOS (is font problem or what), when 
checking bold box, some font won't render to bold (I've check that this may not 
relative to patch, in older commit have this problem, too)."

Have you run gui tests, and in particular, IDLE tests on OSX lately?  Is the 
OSX code in test.support for GUI required still working?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30993] IDLE: Document, fix, and complete configdialog font tests

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +2881

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30993] IDLE: Document, fix, and complete configdialog font tests

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 77e97ca9ff6f3dbbf98b89b4103c46b43eef5642 by Terry Jan Reedy in 
branch 'master':
bpo-30993: IDLE - Improve configdialog font page and tests. (#2831)
https://github.com/python/cpython/commit/77e97ca9ff6f3dbbf98b89b4103c46b43eef5642


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30993] IDLE: Document, fix, and complete configdialog font tests

[Cheryl Sabella]

Cheryl Sabella added the comment:

The tests pass on linux and the htest looks good.  Thank you for making all 
these changes.  It seems much clearer now, but I do want to spend more time 
reading the code to understand it.  Looks like you grouped all the font-related 
functions, so they are ready to become a Class?  The only part I couldn't 
figure out is how to update highlight_sample since it wouldn't be in the class.

With the backwards compatibility, I thought maybe you have an idea about how to 
make the changes compatible because of the issue that moves the extensions.  I 
can see where that would be a problem as far as making changes is concerned.

Maybe I'll look at the creating tests for one of the other tabs next?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30993] IDLE: Document, fix, and complete configdialog font tests

[Terry J. Reedy]

Terry J. Reedy added the comment:

2nd and presumably last PR for this issue: please verify on linux.

--
stage: needs patch -> patch review
title: IDLE: Document and fix configdialog font tests. -> IDLE: Document, fix, 
and complete configdialog font tests

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com