[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

Terry J. Reedy added the comment:

Another big thank you.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 6db2edbe050cc9ac9026f350a24f2d525bcadecd by Terry Jan Reedy in 
branch '3.6':
[3.6] bpo-31001: IDLE: Add tests for configdialog highlight tab (GH-3123) 
(#3124)
https://github.com/python/cpython/commit/6db2edbe050cc9ac9026f350a24f2d525bcadecd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +3162

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 82aff62462e65077a6614b466c986f93a601c33d by Terry Jan Reedy 
(Cheryl Sabella) in branch 'master':
bpo-31001: IDLE: Add tests for configdialog highlight tab (#3123)
https://github.com/python/cpython/commit/82aff62462e65077a6614b466c986f93a601c33d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

Terry J. Reedy added the comment:

Coverage now 95%.  We are getting close.  Still not covered in highlight group: 
 
create_page_highlight:  # Highlight only.
text.bind('', lambda e: 'break')
text.bind('', lambda e: 'break')
Callbacks are never called. I presume that these mask something.  I am not sure 
that they are needed.

save_new:  # Same as for keys.
if not idleConf.userCfg['highlight'].has_section(theme_name): 
Never false.

delete_custom:  # Same as for keys.
if not item_list: 
self.custom_theme_on['state'] = DISABLED 
self.customlist.SetMenu(item_list, '- no custom themes -') 
else: 
self.customlist.SetMenu(item_list, item_list[0]) 
Condition never false, else never executed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +3161

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Cheryl Sabella]

Cheryl Sabella added the comment:

Working on this now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

Terry J. Reedy added the comment:

If we do the same renamings for the theme selection vars and functions as done 
for keys selection on the keys tab, then the corresponding tests can be copied 
and slightly altered.  However, duplicate names require that KeyPage be 
separated first.  Hence the dependency.

When the current mess is replaced on both pages, we *might* be able to make a 
simple Frame subclass tested once and used on both pages.

--
dependencies: +IDLE, configdialog: Factor out KeysPage class from ConfigDialog
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

New submission from Terry J. Reedy:

Pr2908 originally just sorted highlight methods together, but was extended to 
sort all methods together and relabeled for #31060.  (This actually simplified 
the diff.)  Pr2925, the 3.6 backport, appears on the replacement issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +2959

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31001] IDLE: Add tests for configdialog highlight tab

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
assignee: terry.reedy
components: IDLE
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: Add tests for configdialog highlight tab
type: enhancement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com