[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Steve Dower added the comment: Thanks, Tim! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Steve Dower added the comment: New changeset a7ffb663953bc84452af1e5f4089359d54e226b5 by Steve Dower in branch '3.7': [3.7] bpo-31047: Fix ntpath.abspath to trim ending separator (GH-10082) https://github.com/python/cpython/commit/a7ffb663953bc84452af1e5f4089359d54e226b5 --

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Steve Dower added the comment: New changeset 4aa1fda7069642c21c1ee570c4ba2a657e5e by Steve Dower in branch '3.6': bpo-31047: Fix ntpath.abspath to trim ending separator (GH-10082) https://github.com/python/cpython/commit/4aa1fda7069642c21c1ee570c4ba2a657e5e --

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Change by Steve Dower : -- pull_requests: +9430 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Change by Steve Dower : -- pull_requests: +9429 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Steve Dower added the comment: New changeset d03b7757811ae51277f8ed399a9a0fd78dfd3425 by Steve Dower (Tim Graham) in branch 'master': bpo-31047: Fix ntpath.abspath to trim ending separator (GH-10082) https://github.com/python/cpython/commit/d03b7757811ae51277f8ed399a9a0fd78dfd3425

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Change by Tim Graham : -- pull_requests: +9423 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Steve Dower added the comment: Agreed, it no longer matches os.normpath()'s declared behavior by not trimming the end separator. It's obviously too late for the current release (I'd hope Django is one of the projects running tests against RC's, but I guess not :( ), but I think we can fix

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Tim Graham added the comment: I think this caused a behavior change: Before (Python 3.6.6): >>> from os.path import abspath >>> abspath('/abc/') 'C:\\abc' After (Python 3.6.7): >>> abspath('/abc/') 'C:\\abc\\' This causes a test failure in Django's safe_join() function:

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Change by Steve Dower : -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Steve Dower added the comment: New changeset b0bf51b32240369ccb736dc32ff82bb96f375402 by Steve Dower in branch '3.6': bpo-31047: Fix ntpath.abspath for invalid paths (GH-8544) https://github.com/python/cpython/commit/b0bf51b32240369ccb736dc32ff82bb96f375402 --

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

miss-islington added the comment: New changeset 5753b13cb949b939b2b29cec5e2d646f9a30db44 by Miss Islington (bot) in branch '3.7': bpo-31047: Fix ntpath.abspath for invalid paths (GH-8544) https://github.com/python/cpython/commit/5753b13cb949b939b2b29cec5e2d646f9a30db44 -- nosy:

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Change by Steve Dower : -- pull_requests: +8066 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Change by miss-islington : -- pull_requests: +8065 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Steve Dower added the comment: New changeset d2e902e4fb304f27e4a72356efbc1fc26be3935d by Steve Dower (Franz Wöllert) in branch 'master': bpo-31047: Fix ntpath.abspath for invalid paths (GH-8544) https://github.com/python/cpython/commit/d2e902e4fb304f27e4a72356efbc1fc26be3935d --

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Change by Wöllert : -- keywords: +patch pull_requests: +8061 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

Eryk Sun added the comment: The generic abspath implementation could be moved into the genericpath module, where it will be common to both posixpath and ntpath: def abspath(path): """Return an absolute path.""" path = os.fspath(path) if not isabs(path):

[issue31047] Windows: os.path.isabs(os.path.abspath(" ")) == False

New submission from Christoph Reiter: On Windows os.path.abspath(" ") == " " While that's not a valid Windows path, similar invalid paths like "" or "?" etc all produce an absolute path. Tested on 2.7 and 3.6 -- components: Windows messages: 299253 nosy: lazka, paul.moore,