[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

miss-islington added the comment: New changeset fc8ffe27b6f29d67b76fb2ef57466c95af5a9f82 by Miss Islington (bot) in branch '3.9': bpo-31122: ssl.wrap_socket() now raises ssl.SSLEOFError rather than OSError when peer closes connection during TLS negotiation (GH-18772) https://github.com/pytho

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

miss-islington added the comment: New changeset 243458115e2cb295fb5bbb61e6ac528c6b2cf5be by Miss Islington (bot) in branch '3.8': bpo-31122: ssl.wrap_socket() now raises ssl.SSLEOFError rather than OSError when peer closes connection during TLS negotiation (GH-18772) https://github.com/pytho

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Gregory P. Smith added the comment: While this is present in 3.7 (and earlier?), 3.7 is EOL - security fix only stage. the 3.8 and 3.9 PRs should automerge after CI finishes. please reopen the issue or ping me on those PRs if they somehow fail to do so. -- resolution: -> fixed stag

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

miss-islington added the comment: New changeset 495bd035662fda29639f9d52bb6baebea31d72fa by Dima Tisnek in branch 'master': bpo-31122: ssl.wrap_socket() now raises ssl.SSLEOFError rather than OSError when peer closes connection during TLS negotiation (GH-18772) https://github.com/python/cpyt

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Gregory P. Smith added the comment: Thanks! fyi for confirmation incase anyone doubted: >>> issubclass(ssl.SSLEOFError, OSError) True So from a code point of view, anything already catching the error still catches the error. 100% bugfix. -- assignee: christian.heimes -> gregory.p.

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by miss-islington : -- pull_requests: +21007 pull_request: https://github.com/python/cpython/pull/21888 ___ Python tracker ___ __

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by miss-islington : -- pull_requests: +21008 pull_request: https://github.com/python/cpython/pull/21889 ___ Python tracker ___ __

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Safihre added the comment: Would anyone be able to review this? People keep reporting this bug in my project. Months are just passing while the PR is just a few lines of code: https://github.com/python/cpython/pull/18772/files -- ___ Python tracker

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by Joshua Bronson : -- nosy: +jab ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by Rémi Lapeyre : -- nosy: +remi.lapeyre ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Dima Tisnek added the comment: I know Christian is very busy, so what can I do to have this patch reviewed? * it's concise * there's a reproducer -- ___ Python tracker ___ ___

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Dima Tisnek added the comment: If someone can review https://github.com/python/cpython/pull/18772 then pretty-please review 🙏 -- ___ Python tracker ___ ___

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Dima Tisnek added the comment: https://github.com/python/cpython/pull/18772 posted -- ___ Python tracker ___ ___ Python-bugs-list m

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by Dima Tisnek : -- keywords: +patch pull_requests: +18130 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18772 ___ Python tracker _

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Dima Tisnek added the comment: I've traced it down to here: https://github.com/python/cpython/blob/be501ca2419a91546dea85ef4f36945545458589/Modules/_ssl.c#L791-L798 `err.c` (errno) == 0, no error, and `err.ssl` == 5, SSL_ERROR_SYSCALL, helpfully commented "look at error stack/return value/err

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Dima Tisnek added the comment: Rejoice: https://github.com/dimaqq/bpo-31122 Short, easy to reproduce :) (I've tested on Mac: 3.7, 3.8, 3.9a from python.org, linked against OpenSSL 1.1.1c/d) Funnily enough, Python 2.7 raises an ssl.SSLEOFError instead 🤷‍♂️ -- versions: +Python 3.9

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Dima Tisnek added the comment: I volunteer to test the theory that the connection is closed mid-flight. -- ___ Python tracker ___ _

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by Shevis Johnson : -- nosy: +shevis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by Dima Tisnek : -- nosy: +Dima.Tisnek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Safihre added the comment: In the CherryPy project it is also observed on Windows with Python 3,7.2. In CherryPy it's triggered by Checker plugin, which connects to the app listening to the socket port in TLS mode via plain HTTP during startup (from the same process). It has been around for a

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by Gregory P. Smith : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by Gregory P. Smith : -- versions: -Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by Gregory P. Smith : -- versions: +Python 3.6, Python 3.7, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Gregory P. Smith added the comment: This flakiness just caused a PR merge to be blocked by AppVeyor for me: == ERROR: test_with_statement (test.test_nntplib.NetworkedNNTP_SSLTests) -

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Ben Darnell added the comment: We have an easy reproduction of this "[Errno 0] Error" on the server side in https://github.com/tornadoweb/tornado/issues/2504#issuecomment-426782158 It is triggered by a connection from `nc -z` (which I think is doing a TCP handshake and shutting down the conn

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Change by Xavier G. Domingo : -- nosy: +xgdomingo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Nikolaus Rath added the comment: Regarding "atrocious connection": I wish I knew, but I have no control of the connection. All I can tell is that there are frequent disconnects, occasional latency spikes, my remote ip address seems to change frequently (while the apparent local one stays as-is

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

Martin Panter added the comment: It might help if you explained what “atrocities” are happening on your network. Is there a proxy or man-in-the-middle (or the remote peer) that shuts down TCP connections? If so, perhaps this is similar to Issue 10808. From my memory, in that case an OS “recv”

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

New submission from Nikolaus Rath: With a particularly atrocious network connection, I often get the following exception: File "/usr/lib/python3/dist-packages/dugong/__init__.py", line 503, in connect self._sock = self.ssl_context.wrap_socket(self._sock, server_hostname=server_hostname)