[issue3119] pickle.py is limited by python's call stack

Aaron Gallagher added the comment: Definitely not interested in pickle at all anymore. -- ___ Python tracker ___

[issue3119] pickle.py is limited by python's call stack

Changes by Aaron Gallagher <_...@habnab.it>: -- nosy: -habnabit ___ Python tracker ___ ___ Python-bugs-list

[issue3119] pickle.py is limited by python's call stack

Changes by Serhiy Storchaka : -- priority: normal -> low stage: patch review -> needs patch ___ Python tracker ___

[issue3119] pickle.py is limited by python's call stack

Serhiy Storchaka added the comment: It would be nice to support unlimitedly nested structures. C stack is more hard limit than Python stack. But the code of the pickle module (especially C implementation) is complicated and hardly optimized. I think it would be not easy to implement stackless

[issue3119] pickle.py is limited by python's call stack

Tomas Gavenciak added the comment: The issue is still present in Python 2.7.12 and Python 3.5.2, and the implementation has not been changed in the master branch either. You can test it with the attached program constructing a graph (simplified, but a realistic application), or with the

[issue3119] pickle.py is limited by python's call stack

Stéphane Wirtel added the comment: hello, I think we can close this issue because Python 3.1 is not supported. or we keep it if this issue is confirmed for Python 3.6. -- nosy: +matrixise ___ Python tracker

[issue3119] pickle.py is limited by python's call stack

Tomas Gavenciak added the comment: Hey all, I would like to patch the C _pickle module to be non-recursive and help this patch go through. I have an idea on how to do that with a very small amount of changes below and I would like to get feedback and improvements before implementing it in a

[issue3119] pickle.py is limited by python's call stack

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3119 ___ ___

[issue3119] pickle.py is limited by python's call stack

Changes by Éric Araujo mer...@netwok.org: -- superseder: eliminate recursion in pickling - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3119 ___

[issue3119] pickle.py is limited by python's call stack

Aaron Gallagher habna...@gmail.com added the comment: Here's a patch that fixes the unit tests. A new test was added that tried to test the C implementation of this though none exists. -- keywords: +patch Added file: http://bugs.python.org/file18073/pickle4.patch

[issue3119] pickle.py is limited by python's call stack

Mark Lawrence breamore...@yahoo.co.uk added the comment: Sean has stated that the patch seems fine, what needs to be done to take this forward? -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3119

[issue3119] pickle.py is limited by python's call stack

Sean Reifschneider j...@tummy.com added the comment: Sorry for the delay in getting to this patch. I've reviewed this patch and it seems fine to me. The only thing I see outstanding is the recommendation made by Alexandre about changing the C module to also implement this. Aaron: You may

[issue3119] pickle.py is limited by python's call stack

Sean Reifschneider j...@tummy.com added the comment: Ugh, I forgot to check the output of my test run before submitting the last reply. With the patch applied, make test fails with: test_pickle Fatal Python error: Cannot recover from stack overflow. Fatal Python error: Cannot recover from

[issue3119] pickle.py is limited by python's call stack

Changes by Tennessee Leeuwenburg tleeuwenb...@gmail.com: -- keywords: +needs review -patch stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3119 ___

[issue3119] pickle.py is limited by python's call stack

Aaron Gallagher habna...@gmail.com added the comment: Okay, here's a new version for the py3k trunk. I'm assuming that this is not going to make it into 2.x at all, because of the API changes. This patch only touches the python version of the code and adds a unit test for testing whether

[issue3119] pickle.py is limited by python's call stack

Tennessee Leeuwenburg tleeuwenb...@gmail.com added the comment: Aaron, Could you please upload another patch against the current trunk, then the issue could be flagged as requiring a patch review? Thanks, -Tennessee -- nosy: +tleeuwenb...@gmail.com

[issue3119] pickle.py is limited by python's call stack

Aaron Gallagher [EMAIL PROTECTED] added the comment: Alright, sorry this took so long. Hopefully this can still be included in 3.0. Included is a patch that no longer uses collections.deque and also adds a test case to test/test_pickle.py. The test catches RuntimeError and fails the unittest.

[issue3119] pickle.py is limited by python's call stack

Alexandre Vassalotti [EMAIL PROTECTED] added the comment: On some benchmark of my own, I get a good 2x slowdown when this patch is applied. The benchmark consists of loading ~1.4 millions objects (mostly dict, list, str and int) from a pickle string. It is basically a torture test for the inner

[issue3119] pickle.py is limited by python's call stack

Changes by Gregory P. Smith [EMAIL PROTECTED]: -- superseder: - eliminate recursion in pickling ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3119 ___

[issue3119] pickle.py is limited by python's call stack

Changes by Ralf Schmitt [EMAIL PROTECTED]: -- nosy: +schmir ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3119 ___ ___ Python-bugs-list mailing list

[issue3119] pickle.py is limited by python's call stack

Aaron Gallagher [EMAIL PROTECTED] added the comment: Ah, I didn't know that a list would be as fast for appending and popping. I knew that lists were optimized for .append() and .pop(), but I didn't know that a list would be just as fast as a deque if it was just used as a stack. And I'll be

[issue3119] pickle.py is limited by python's call stack

Antoine Pitrou [EMAIL PROTECTED] added the comment: Hi, Le mercredi 02 juillet 2008 à 20:43 +, Aaron Gallagher a écrit : Aaron Gallagher [EMAIL PROTECTED] added the comment: Ah, I didn't know that a list would be as fast for appending and popping. I knew that lists were optimized for

[issue3119] pickle.py is limited by python's call stack

Changes by Jesús Cea Avión [EMAIL PROTECTED]: -- nosy: +jcea ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3119 ___ ___ Python-bugs-list mailing list

[issue3119] pickle.py is limited by python's call stack

New submission from Aaron Gallagher [EMAIL PROTECTED]: Currently, pickle.py in the stdlib is limited by the python call stack. For deeply recursive data structures, the default recursion limit of 1000 is not enough. The patch attached modifies pickle.py to instead use a deque object as a call