[issue31243] checks whether PyArg_ParseTuple returned a negative int

Serhiy Storchaka added the comment: Thank you for your contribution Oren! -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Serhiy Storchaka added the comment: New changeset 20958e6d91d11a80d6c664ce6346791259b1d193 by Serhiy Storchaka (Oren Milman) in branch '2.7': [2.7] bpo-31243: Fixed PyArg_ParseTuple failure checks. (GH-3171) (#3235)

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Changes by Oren Milman : -- pull_requests: +3276 ___ Python tracker ___ ___

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Serhiy Storchaka added the comment: New changeset c7750c2a3af014a5b742d0159d8957ea95b6c221 by Serhiy Storchaka (Oren Milman) in branch '3.6': [3.6] bpo-31243: Fixed PyArg_ParseTuple failure checks. (GH-3171) (#3233)

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Changes by Oren Milman : -- pull_requests: +3275 ___ Python tracker ___ ___

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Changes by Serhiy Storchaka : -- stage: needs patch -> backport needed ___ Python tracker ___

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Serhiy Storchaka added the comment: New changeset ba7d7365215d791025d1efd25393c91404f2cfc8 by Serhiy Storchaka (Oren Milman) in branch 'master': bpo-31243: Fixed PyArg_ParseTuple failure checks. (#3171) https://github.com/python/cpython/commit/ba7d7365215d791025d1efd25393c91404f2cfc8

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Changes by Serhiy Storchaka : -- components: +IO nosy: +benjamin.peterson, stutzbach ___ Python tracker ___

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Changes by Oren Milman : -- pull_requests: +3208 ___ Python tracker ___ ___

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Oren Milman added the comment: yes, soon. (just wanted to hear your opinion before doing that.) -- ___ Python tracker ___

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka keywords: +easy (C) ___ Python tracker ___

[issue31243] checks whether PyArg_ParseTuple returned a negative int

Serhiy Storchaka added the comment: Do you want to provide a PR Oren? -- components: +Extension Modules -Interpreter Core nosy: +serhiy.storchaka stage: -> needs patch versions: +Python 2.7, Python 3.6 ___ Python tracker

[issue31243] checks whether PyArg_ParseTuple returned a negative int

New submission from Oren Milman: according to the docs (https://docs.python.org/3.7/c-api/arg.html?highlight=pyarg_parsetuple#c.PyArg_ParseTuple), PyArg_ParseTuple returns true for success or false for failure. I also looked at the implementation in Python/getargs.c, and it seems that indeed