[issue31853] Use super().method instead of socket.method in SSLSocket

Christian Heimes added the comment: I agree Also this ticket was closed a couple of months ago and is about the SSL module. Your PR is about a different module. Although I think that recycling is generally a good idea, it doesn't apply to ticket numbers. --

[issue31853] Use super().method instead of socket.method in SSLSocket

Nathaniel Smith added the comment: The only time this should matter semantically is if someone is trying to subclass SSLSocket and use multiple inheritance. This is something that people *really* shouldn't do. It also potentially makes it harder to backport ssl changes to

[issue31853] Use super().method instead of socket.method in SSLSocket

INADA Naoki added the comment: Why *should*? Legacy ParentClass.method() call is faster than super().method() call, because there are no temporary proxy object. I don't think there are enough reason to replace all legacy parent calls. -- nosy: +inada.naoki

[issue31853] Use super().method instead of socket.method in SSLSocket

Mads Jensen added the comment: There are lots of legacy calls in the form of ClassName.method, which should be replaced with super().method. -- components: +email -SSL nosy: +barry, r.david.murray pull_requests: +5996 ___ Python

[issue31853] Use super().method instead of socket.method in SSLSocket

Change by Christian Heimes : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31853] Use super().method instead of socket.method in SSLSocket

Christian Heimes added the comment: New changeset 746cc75541f31278864a10b995e7d009bd2ff053 by Christian Heimes (Mads Jensen) in branch 'master': bpo-31853: Replaced socket.method calls with super() in SSLSocket. (#4048)

[issue31853] Use super().method instead of socket.method in SSLSocket

Change by Berker Peksag : -- nosy: +earonesty ___ Python tracker ___ ___

[issue31853] Use super().method instead of socket.method in SSLSocket

Change by Mads Jensen : -- nosy: +madsjensen -earonesty ___ Python tracker ___ ___

[issue31853] Use super().method instead of socket.method in SSLSocket

New submission from Erik Aronesty : I asked on #python-dev and was told that it's most likely due to legacy reasons that the class has things like `socket.__init__` instead of `super().__init__` -- assignee: christian.heimes components: SSL messages: 304838 nosy: