[issue31897] Unexpected exceptions in plistlib.loads

2017-11-20 Thread Serhiy Storchaka 

Serhiy Storchaka  added the comment:

Opened issue32072 for infinite recursion and related issues.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31897] Unexpected exceptions in plistlib.loads

2017-10-31 Thread Serhiy Storchaka 

Serhiy Storchaka  added the comment:


New changeset 6969d368c43d4c97e5f7b7b22904305ec68f79ba by Serhiy Storchaka 
(Miss Islington (bot)) in branch '3.6':
bpo-31897: Convert unexpected errors when read bogus binary plists into 
InvalidFileException. (GH-4171) (#4192)
https://github.com/python/cpython/commit/6969d368c43d4c97e5f7b7b22904305ec68f79ba


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31897] Unexpected exceptions in plistlib.loads

2017-10-31 Thread Roundup Robot 

Change by Roundup Robot :


--
pull_requests: +4162

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31897] Unexpected exceptions in plistlib.loads

2017-10-31 Thread Serhiy Storchaka 

Serhiy Storchaka  added the comment:


New changeset db91e0fe2417f075693a194a492b1699829871e7 by Serhiy Storchaka in 
branch 'master':
bpo-31897: Convert unexpected errors when read bogus binary plists into 
InvalidFileException. (#4171)
https://github.com/python/cpython/commit/db91e0fe2417f075693a194a492b1699829871e7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31897] Unexpected exceptions in plistlib.loads

2017-10-30 Thread Ned Williamson 

Ned Williamson  added the comment:

Thank you for the quick PR! I will report as behavior next time. I'm also 
following the library reference and reporting only unexpected exceptions.

I trust you to reject any bugs that are expected functionality.

I may follow up with additional testcases once the first PR is accepted.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31897] Unexpected exceptions in plistlib.loads

2017-10-30 Thread Serhiy Storchaka 

Serhiy Storchaka  added the comment:

PR 4171 fixes the following errors:

1. OverflowError is raised by seek() for too large offsets of objects or the 
offset table.

2. Since read() past the file returns b'' and int.from_bytes() used for 
non-standard sizes accepts b'', bogus offsets and references can be read. This 
can cause an infinity recursion.

3. The zero size of offsets or references causes ValueError. This is 
implementation detail.

4. Unicode errors of decoding from invalid ASCII and UTF-8.

It doesn't verify the binary plist, a bogus plist can be successfully parsed to 
a bogus data. And it doesn't prevent infinity recursion when read cyclic 
references.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31897] Unexpected exceptions in plistlib.loads

2017-10-30 Thread Serhiy Storchaka 

Change by Serhiy Storchaka :


--
nosy: +ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31897] Unexpected exceptions in plistlib.loads

2017-10-30 Thread Serhiy Storchaka 

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +4140
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31897] Unexpected exceptions in plistlib.loads

2017-10-30 Thread Serhiy Storchaka 

Change by Serhiy Storchaka :


--
title: RecursionError in plistlib.loads -> Unexpected exceptions in 
plistlib.loads

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com