[issue32021] Brotli encoding is not recognized by mimetypes

Change by Abhilash Raj : -- stage: patch review -> resolved status: open -> closed versions: -Python 3.8 ___ Python tracker ___

[issue32021] Brotli encoding is not recognized by mimetypes

Abhilash Raj added the comment: New changeset b2b4a51f7463a0392456f7772f33223e57fa4ccc by Abhilash Raj (Philip McMahon) in branch 'master': bpo-32021: Support brotli .br encoding in mimetypes (#12200) https://github.com/python/cpython/commit/b2b4a51f7463a0392456f7772f33223e57fa4ccc

[issue32021] Brotli encoding is not recognized by mimetypes

Cheryl Sabella added the comment: Now that two years have passed, is there any additional info as to whether this should be added or not? It does seem that the format is active (https://github.com/google/brotli). -- nosy: +cheryl.sabella versions: +Python 3.8, Python 3.9 -Python

[issue32021] Brotli encoding is not recognized by mimetypes

Change by Roundup Robot : -- keywords: +patch pull_requests: +12195 stage: -> patch review ___ Python tracker ___ ___

[issue32021] Brotli encoding is not recognized by mimetypes

R. David Murray added the comment: OK, bouncing around from those URL I finally found this: https://github.com/google/ngx_brotli/issues/28 That indicates unambiguously that someone does expect files to be pre-compressed on the server and that the main brotli package

[issue32021] Brotli encoding is not recognized by mimetypes

Andrey added the comment: NodeJS: https://www.npmjs.com/package/brotli Python: https://pypi.python.org/pypi/brotlipy https://pypi.python.org/pypi/Brotli Ubuntu: https://launchpad.net/ubuntu/+source/brotli That said I don't expect an average user to compress their files as

[issue32021] Brotli encoding is not recognized by mimetypes

R. David Murray added the comment: Hmm. OK, the docs do say that value should be usable as a content-encoding header. However, absent any sort of program that actually does brotli encoding/decoding to and from files, this would be essentially useless based on the

[issue32021] Brotli encoding is not recognized by mimetypes

Andrey added the comment: Currently aiohttp doesn't support Brotli. (I'm here because I would like to get that support) When it gets (as a server) a request for file.html it checks if file.html.gz exists (and accept-encoding contains 'gzip'). It then send file.html.gz to

[issue32021] Brotli encoding is not recognized by mimetypes

R. David Murray added the comment: Note, I'm not saying we shouldn't do this, I'd just like to get good documentation of why linked to this issue. -- ___ Python tracker

[issue32021] Brotli encoding is not recognized by mimetypes

R. David Murray added the comment: OK, so there are "real" filenames that have .br on the end? That wasn't clear from the RFC and discussions I found. Based on the documentation, br is for use in the Content-Encoding header. What does aiohttp do when it gets a brotli

[issue32021] Brotli encoding is not recognized by mimetypes

Andrey added the comment: When "type, encoding = mimetypes.guess_type('file.js.br')" is used not only the "encoding" is not set to "brotli", but the type is also not recognized. Such code is used in aiohttp for example. My proposal is to add 'br' to

[issue32021] Brotli encoding is not recognized by mimetypes

R. David Murray added the comment: It looks like Brotli is a de-facto standard (RFC 7932 is an informational RFC), and it says the IANA registry has been updated. However, this appears to be http-only, with no corresponding program used for compression of files, and

[issue32021] Brotli encoding is not recognized by mimetypes

Andrey added the comment: Yes, however would it make sense to add it, so mimetypes recognizes it by default? I will make a PR if it makes sense. -- ___ Python tracker

[issue32021] Brotli encoding is not recognized by mimetypes

Christian Heimes added the comment: You can just add the encoding to mimetypes.encodings_map: mimetypes.encodings_map['.br'] = 'brotli' -- nosy: +christian.heimes versions: -Python 3.4, Python 3.5, Python 3.8 ___ Python tracker

[issue32021] Brotli encoding is not recognized by mimetypes

New submission from Andrey Klinger : Brotli (.br) encoding is not recognized by mimetypes module. mimetypes doesn't have API for adding encodings. The encoding is supported by most browsers: https://caniuse.com/#feat=brotli -- components: Library (Lib) messages: