[issue32139] android: locale is modified by test_strftime

[Xavier de Gaye]

Xavier de Gaye  added the comment:

Closing now.
Thanks Victor :-)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32139] android: locale is modified by test_strftime

[Xavier de Gaye]

Xavier de Gaye  added the comment:


New changeset bc19cf57a8f061bbb1961aa069ed54e8361023ae by xdegaye (Miss 
Islington (bot)) in branch '2.7':
bpo-32139: test_strftime does not anymore modify the locale (GH-4569) (#4636)
https://github.com/python/cpython/commit/bc19cf57a8f061bbb1961aa069ed54e8361023ae


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32139] android: locale is modified by test_strftime

[Xavier de Gaye]

Xavier de Gaye  added the comment:


New changeset b0df786258c99f98295b82ec62daea1f49912c33 by xdegaye (Miss 
Islington (bot)) in branch '3.6':
bpo-32139: test_strftime does not anymore modify the locale (GH-4569) (#4635)
https://github.com/python/cpython/commit/b0df786258c99f98295b82ec62daea1f49912c33


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32139] android: locale is modified by test_strftime

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4551

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32139] android: locale is modified by test_strftime

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4550
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32139] android: locale is modified by test_strftime

[STINNER Victor]

STINNER Victor  added the comment:

Python 3.6 and 2.7 are also affected and should be fixed. I requested automated 
backports.

--
nosy: +vstinner
resolution: fixed -> 
status: closed -> open
versions: +Python 2.7, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32139] android: locale is modified by test_strftime

[Xavier de Gaye]

Change by Xavier de Gaye :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32139] android: locale is modified by test_strftime

[Xavier de Gaye]

Xavier de Gaye  added the comment:


New changeset cc55e78acab93a495c974b9a2ea71c8bb9cc2f5d by xdegaye in branch 
'master':
bpo-32139: test_strftime does not anymore modify the locale (GH-4569)
https://github.com/python/cpython/commit/cc55e78acab93a495c974b9a2ea71c8bb9cc2f5d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32139] android: locale is modified by test_strftime

[Xavier de Gaye]

Change by Xavier de Gaye :


--
keywords: +patch
pull_requests: +4497
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32139] android: locale is modified by test_strftime

[Xavier de Gaye]

New submission from Xavier de Gaye :

Test results:

1 test altered the execution environment:
  test_strftime

Warning -- locale was modified by test_strftime
  Before: [(6, 'C.UTF-8'), (3, 'C.UTF-8'), (0, 'C.UTF-8'), (5, 'C.UTF-8'), 
(4, 'C.UTF-8'), (1, 'C.UTF-8'), (2, 'C.UTF-8')]
  After:  [(6, 'C'), (3, 'C'), (0, 'C'), (5, 'C'), (4, 'C'), (1, 'C'), (2, 
'C')] 
test_strftime failed (env changed)


It seems that the tests indeed modify the environment. To understand the above 
results one must be aware that the implementation of setlocale() is broken on 
Android:

generic_x86_64:/data/local/tmp/python $ python
Python 3.7.0a2+ (heads/bpo-30386:ebb493ac4e, Nov 25 2017, 18:58:20) 
[Clang 3.8.275480 ] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from locale import setlocale, LC_TIME, LC_ALL
>>> setlocale(LC_TIME)
'C.UTF-8'
>>> setlocale(LC_ALL)
'C.UTF-8'
>>> setlocale(LC_TIME, 'C')
'C'
>>> setlocale(LC_TIME)
'C'
>>> setlocale(LC_ALL)
'C'
>>> setlocale(LC_TIME, 'C.UTF-8')
'C.UTF-8'
>>> setlocale(LC_ALL)
'C.UTF-8'

--
components: Tests
messages: 307000
nosy: xdegaye
priority: normal
severity: normal
stage: needs patch
status: open
title: android: locale is modified by test_strftime
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com