[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Barry A. Warsaw added the comment: Now that the zipimporter support has landed, I think we're done! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Barry A. Warsaw added the comment: New changeset 6f6eb35f9bee18f54945f09664344f2d118ed89f by Barry Warsaw in branch 'master': bpo-32248 - Implement `ResourceReader` and `get_resource_reader()` for zipimport (#5248)

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by Barry A. Warsaw : -- pull_requests: +5093 ___ Python tracker ___ ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

STINNER Victor added the comment: New changeset 3a0cf931796b9ad1b4833ab89c79d284b4253c91 by Victor Stinner in branch 'master': bpo-32248: Fix test_importlib.test_open() (#5213) https://github.com/python/cpython/commit/3a0cf931796b9ad1b4833ab89c79d284b4253c91

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by STINNER Victor : -- pull_requests: +5067 ___ Python tracker ___ ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

STINNER Victor added the comment: New changeset 44a70e9336765404057b12345465844dc291297a by Victor Stinner in branch 'master': Fix Git attributes of test_importlib data files (#5209) https://github.com/python/cpython/commit/44a70e9336765404057b12345465844dc291297a

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by Barry A. Warsaw : -- pull_requests: -5016 ___ Python tracker ___ ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by STINNER Victor : -- pull_requests: +5064 ___ Python tracker ___ ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Brett Cannon added the comment: New changeset bca42186b69e2e615d29d0d4fdb493c9fe71c48b by Brett Cannon in branch 'master': bpo-32248: Introduce the concept of Loader.get_resource_reader() (GH-5108)

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by bbayles : -- pull_requests: +5016 ___ Python tracker ___ ___ Python-bugs-list

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by Barry A. Warsaw : -- pull_requests: -5006 ___ Python tracker ___ ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Barry A. Warsaw added the comment: @bbayles: I don't think PR 5149 is related to this issue. -- ___ Python tracker ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by bbayles : -- pull_requests: +5006 ___ Python tracker ___ ___ Python-bugs-list

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by Ned Deily : -- pull_requests: +4998 ___ Python tracker ___ ___ Python-bugs-list

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

STINNER Victor added the comment: Failure on x86 Gentoo Installed with X 3.x: http://buildbot.python.org/all/#/builders/103/builds/453 4 tests failed: test_compileall test_import test_importlib test_inspect test test_import crashed -- Traceback (most recent call

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

STINNER Victor added the comment: Tests fail on Windows since the commit deae6b451fefd5fd3143dd65051e1d341e5a5f84. Example with AMD64 Windows8.1 Non-Debug 3.x: http://buildbot.python.org/all/#/builders/12/builds/426

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Barry A. Warsaw added the comment: On Jan 6, 2018, at 13:33, Zachary Ware wrote: > > I notice that my 'Installed' builder > (http://buildbot.python.org/all/#/builders/103) has been broken since PR4911 > landed. My suspicion is that it's just

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Brett Cannon added the comment: I bet Barry forgot to add some test directories to the makefile. On Sat, Jan 6, 2018, 10:33 Zachary Ware, wrote: > > Zachary Ware added the comment: > > I notice that my 'Installed' builder ( >

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Zachary Ware added the comment: I notice that my 'Installed' builder (http://buildbot.python.org/all/#/builders/103) has been broken since PR4911 landed. My suspicion is that it's just another directory missed in the Makefile install libinstall target, but haven't

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by Brett Cannon : -- pull_requests: +4975 ___ Python tracker ___ ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

David Bolen added the comment: Apologies if this is obvious and already in progress, but the issue with Windows and this change appears to be that the "utf-8.file" file is being treated as text rather than binary. So the line ending is expanding to CRLF. The working copy

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Barry A. Warsaw added the comment: Next up - implementing the ResourceReader ABC. -- ___ Python tracker ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Barry A. Warsaw added the comment: New changeset deae6b451fefd5fd3143dd65051e1d341e5a5f84 by Barry Warsaw in branch 'master': bpo-32248 - Implement importlib.resources (#4911) https://github.com/python/cpython/commit/deae6b451fefd5fd3143dd65051e1d341e5a5f84 --

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Brett Cannon added the comment: Yep, I assumed implementing the ReourceReader API would be a separate step. As for the type hints, I thought it was lifted such that new code could include it but we wouldn't be taking PRs to add them to pre-existing code? --

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Barry A. Warsaw added the comment: PR 4911 implements the importlib.resources API, along with tests and documentation. @brett.cannon - I'm thinking we should do the native ResourceReader implementations for the built-in loaders as a separate branch. --

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by Barry A. Warsaw : -- pull_requests: +4805 ___ Python tracker ___ ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Barry A. Warsaw added the comment: I have the tests and code ported, but there are still a few things to do, but here's a question: We're using type annotations in importlib_resources, which of course is the right decision. But I think we still have a moratorium on typing

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Brett Cannon added the comment: New changeset 4ac5150e068a3a795ef00465f6dff51747b62b91 by Brett Cannon in branch 'master': bpo-32248: Implement importlib.abc.ResourceReader (GH-4892) https://github.com/python/cpython/commit/4ac5150e068a3a795ef00465f6dff51747b62b91

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by Brett Cannon : -- keywords: +patch pull_requests: +4785 stage: -> patch review ___ Python tracker ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

Change by Gregory P. Smith : -- nosy: +gregory.p.smith, twouters ___ Python tracker ___ ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

New submission from Barry A. Warsaw : We intend to port importlib_resources to Python 3.7 as importlib.resources, with a provisional API. There's also a ResourceReader ABC to include, along with documentation and tests. Nosying Brett and assigning to myself, but if Brett