[issue32370] Wrong ANSI encoding used by subprocess for some locales

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32370] Wrong ANSI encoding used by subprocess for some locales

Serhiy Storchaka added the comment: New changeset c3f9d7e0ea30e94c901d13e1d43ff0be1e5dbcb7 by Serhiy Storchaka in branch '3.6': [3.6] bpo-32370: Use the correct encoding for ipconfig output in the uuid module. (GH-5608). (#5654)

[issue32370] Wrong ANSI encoding used by subprocess for some locales

miss-islington added the comment: New changeset 9b5a90b975ef32b261d60b8ec06504f4ffd00d63 by Miss Islington (bot) in branch '3.7': bpo-32370: Use the correct encoding for ipconfig output in the uuid module. (GH-5608)

[issue32370] Wrong ANSI encoding used by subprocess for some locales

Change by Serhiy Storchaka : -- pull_requests: +5456 ___ Python tracker ___ ___

[issue32370] Wrong ANSI encoding used by subprocess for some locales

Change by miss-islington : -- pull_requests: +5454 ___ Python tracker ___

[issue32370] Wrong ANSI encoding used by subprocess for some locales

Serhiy Storchaka added the comment: New changeset da6c3da6c33c6bf794f741e348b9c6d86cc43ec5 by Serhiy Storchaka (Segev Finer) in branch 'master': bpo-32370: Use the correct encoding for ipconfig output in the uuid module. (GH-5608)

[issue32370] Wrong ANSI encoding used by subprocess for some locales

Change by Serhiy Storchaka : -- versions: +Python 3.6 ___ Python tracker ___

[issue32370] Wrong ANSI encoding used by subprocess for some locales

Steve Dower added the comment: The patch looks good, but the rest of the code for this looks horrible(and potentially a security risk)... maybe we ought to take this fix for now but prioritise replacing this whole function with a C implementation or at least a better

[issue32370] Wrong ANSI encoding used by subprocess for some locales

Change by Segev Finer : -- versions: +Python 3.8 ___ Python tracker ___ ___

[issue32370] Wrong ANSI encoding used by subprocess for some locales

Change by Segev Finer : -- keywords: +patch pull_requests: +5418 stage: -> patch review ___ Python tracker ___

[issue32370] Wrong ANSI encoding used by subprocess for some locales

Eryk Sun added the comment: ipconfig uses (or defaults to) OEM encoded output when writing to a pipe or file. On the other hand, Python's TextIOWrapper defaults to ANSI (i.e. 'mbcs'). In 3.6+, uuid._ipconfig_getnode could be rewritten to call subprocess.Popen with the new

[issue32370] Wrong ANSI encoding used by subprocess for some locales

New submission from Segev Finer : The following test is failing randomly for me (python -m test test_uuid -v): == ERROR: test_ipconfig_getnode (test.test_uuid.TestInternalsWithoutExtModule)