[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Steve Dower added the comment: New changeset 1d3c518c5ecbd78478738f068f4f035f81f035f9 by Steve Dower in branch '3.6': bpo-32457: Improves handling of denormalized executable path when launching Python (GH-5756) (#5818)

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Change by Steve Dower : -- pull_requests: +5594 ___ Python tracker ___ ___

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

miss-islington added the comment: New changeset e5a9b3574c89a070fbc43caf541759f504e3d492 by Miss Islington (bot) in branch '3.7': bpo-32457: Improves handling of denormalized executable path when launching Python (GH-5756)

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Change by miss-islington : -- pull_requests: +5592 ___ Python tracker ___

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Steve Dower added the comment: New changeset 48e8c82fc63d2ddcddce8aa637a892839b551619 by Steve Dower in branch 'master': bpo-32457: Improves handling of denormalized executable path when launching Python (GH-5756)

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Change by Steve Dower : -- keywords: +patch pull_requests: +5534 stage: needs patch -> patch review ___ Python tracker ___

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Change by Steve Dower : -- assignee: -> steve.dower ___ Python tracker ___ ___

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Eryk Sun added the comment: For extra measure, you may want to normalize `prefix` prior to calculating its length n in gotlandmark(). Then it would be reliable to truncate it via `prefix[n] = '\0'` after joining with `landmark`. Or at least add a comment there or in the

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Change by Steve Dower : -- stage: -> needs patch versions: +Python 3.7, Python 3.8 ___ Python tracker ___

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Steve Dower added the comment: I agree that explicitly normalizing in PC/getpathp.c is the correct approach. As far as I'm aware, GetModuleFileNameW(NULL) can never fail other than a buffer that is too small, so that whole function can probably be simplified to abort

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Eryk Sun added the comment: Here's a way to trigger this error that's unrelated to the PATH environment variable: >>> subprocess.call('python', executable=r'C:\Program Files\Python36\.\python.exe') Fatal Python error: Py_Initialize: unable to load the file system

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

Ray Donnelly added the comment: .. though I will also ask the scons people to change this to use pushd and %CD% instead. Even if you were to make Python capable of handling such bad input, who knows what other programs will fail, and build systems should be extra

[issue32457] Windows Python cannot handle an early PATH entry containing ".." and python.exe

New submission from Ray Donnelly : Over on the Anaconda Distribution we received a (private) bug report about a crash when trying to use scons. I thought initially it was due to one of our patches but I tested it out with official CPython and also with WinPython and