[issue32572] Add the ftplib option, overrides the IP address.

2018-02-01 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Considering the security implications and the fact that it's a corner case I don't think this is worth adding as a new, public API, sorry. I think ftplib should expose and promote APIs reflecting common scenarios and good practices,

[issue32572] Add the ftplib option, overrides the IP address.

2018-02-01 Thread Hideyuki
Hideyuki added the comment: I understand that it is best to use PASV. But this FTP server is managed by another person, and that server required active mode. Also, my host is in a VPC environment, it is connected by 1:1 NAT. This NAT BOX does not support FTP transparent.

[issue32572] Add the ftplib option, overrides the IP address.

2018-02-01 Thread R. David Murray
R. David Murray added the comment: I too wondered if pasv was the correct solution to the problem. -- ___ Python tracker ___

[issue32572] Add the ftplib option, overrides the IP address.

2018-02-01 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Mmmm out of curiosity, how common is this? Usually when client is behind a NAT it's supposed to use PASV. What you're proposing is a configuration option which typically belong to servers, not clients. I don't remember ever bumping

[issue32572] Add the ftplib option, overrides the IP address.

2018-02-01 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: +1 for this point David, but also the minimum is the documentation and a test, I suppose you will confirm. -- ___ Python tracker

[issue32572] Add the ftplib option, overrides the IP address.

2018-02-01 Thread R. David Murray
R. David Murray added the comment: I'd like confirmation from someone involved in maintaining the ftplib package that this is in fact the correct solution. -- nosy: +r.david.murray ___ Python tracker

[issue32572] Add the ftplib option, overrides the IP address.

2018-02-01 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Hi Hideyuki, Thank you for your contribution but we need some changes from your PR. 1. Could you add a documentation in Doc/library/ftplib.rst +- line 170, after FTP.set_debuglevel ? 2. There is no tests, please could you add a test in

[issue32572] Add the ftplib option, overrides the IP address.

2018-01-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- nosy: +giampaolo.rodola versions: -Python 3.6, Python 3.7 ___ Python tracker ___

[issue32572] Add the ftplib option, overrides the IP address.

2018-01-16 Thread Hideyuki
Change by Hideyuki : -- keywords: +patch pull_requests: +5061 stage: -> patch review ___ Python tracker ___

[issue32572] Add the ftplib option, overrides the IP address.

2018-01-16 Thread Hideyuki
New submission from Hideyuki : Add the ftplib's option, overrides the IP address to be used with the PORT command. Currently, the PORT command is sending its self IP address. If the host is connected with NAT, it will not work. If that command has a NAT external IP address, it