[issue32688] weird comment out line of code

Brett Cannon added the comment: Thanks! On Sun, Jan 28, 2018, 19:32 Xiang Zhang, wrote: > > Xiang Zhang added the comment: > > Done. > > -- > versions: -Python 3.6 > > ___ > Python

[issue32688] weird comment out line of code

Xiang Zhang added the comment: Done. -- versions: -Python 3.6 ___ Python tracker ___ ___

[issue32688] weird comment out line of code

Xiang Zhang added the comment: New changeset 997478eb797b31bd724135ca17781d1cf4b89cfa by Xiang Zhang in branch 'master': bpo-32688: Make why the line is commented out clear (GH-5405) https://github.com/python/cpython/commit/997478eb797b31bd724135ca17781d1cf4b89cfa

[issue32688] weird comment out line of code

Change by Xiang Zhang : -- pull_requests: +5238 ___ Python tracker ___ ___

[issue32688] weird comment out line of code

Brett Cannon added the comment: We should probably delete the line regardless so no one else gets thrown by this (or at least leave a comment). -- ___ Python tracker

[issue32688] weird comment out line of code

Xiang Zhang added the comment: Ahh, I figure out that the line is useless and can't affect any logic then. So the analyzer is right! Sorry for the bother Brett. -- resolution: -> not a bug stage: -> resolved status: open -> closed

[issue32688] weird comment out line of code

Brett Cannon added the comment: I don't remember why that line was commented out to make the analyzer happy. -- ___ Python tracker

[issue32688] weird comment out line of code

Xiang Zhang added the comment: Sorry, forget links, it's https://github.com/python/cpython/blob/master/Python/ceval.c#L3528 , and the commit is b94767ff44edf5d461d7cb1c8eb5160f83886358. -- ___ Python tracker

[issue32688] weird comment out line of code

New submission from Xiang Zhang : I find one line[1] is weirdly commented out. But I don't think profile here is any different with trace. In 2.7, this line is not commented out and the change happens in b94767ff, fixing clang warnings. -- messages: 310866 nosy: