[issue32826] idle test fails at least on the 3.6 branch

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Serhiy, thanks for comment and review.
Cheryl, #32837 expands upon your comment.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[miss-islington]

miss-islington  added the comment:


New changeset 46daf39453023767eef3b6876d4a34996e124397 by Miss Islington (bot) 
in branch '3.6':
bpo-32826: Add "encoding=utf-8" to open() in idle_test/test_help_about. 
(GH-5639)
https://github.com/python/cpython/commit/46daf39453023767eef3b6876d4a34996e124397


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[miss-islington]

miss-islington  added the comment:


New changeset 38b4dd7f83fbdce6fe970088cd89b80f074a13f6 by Miss Islington (bot) 
in branch '3.7':
bpo-32826: Add "encoding=utf-8" to open() in idle_test/test_help_about. 
(GH-5639)
https://github.com/python/cpython/commit/38b4dd7f83fbdce6fe970088cd89b80f074a13f6


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[miss-islington]

Change by miss-islington :


--
pull_requests: +5443

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[miss-islington]

Change by miss-islington :


--
pull_requests: +5442
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset f34e03ec0ea6a4cef8d966087c77e616c4a5893b by Terry Jan Reedy in 
branch 'master':
bpo-32826: Add "encoding=utf-8" to open() in idle_test/test_help_about. 
(GH-5639)
https://github.com/python/cpython/commit/f34e03ec0ea6a4cef8d966087c77e616c4a5893b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I reproduced the exact failure by temporarily replacing 'utf-8' with 'ascii' in 
my clone.  So I don't need anyone else to verify the fix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[Cheryl Sabella]

Cheryl Sabella  added the comment:

I've been able to run the IDLE test suite on Linux.

As far as this issue, there's also a readline in test_textview that you may 
want to add the encoding to, even though it's only reading __file__.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I just discovered that the default for me is some version of latin1, not ascii, 
so that utf-8 'ö' is read as 'ö'.  Hence, no UnicodeDecodeError even if 'ö' is 
being read and decoded by the initial readline call.  I presume the same is 
true on current Windows buildbots.  Hence, it was a bug to not include an 
encoding in the test file open calls.  (The widget itself *does* use explicit 
'ascii' or 'utf-8' encodings for open().)

--
components:  -Tests
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[Terry J. Reedy]

Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +5439
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

The failure is reproduced on Posix locale. Files are open with bare open() 
which uses the locale encoding by default. Which is ASCII in this case.

--
components: +Tests
keywords: +easy
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[Terry J. Reedy]

Terry J. Reedy  added the comment:

What system?  test_idle passes on Windows.  Unfortunately, none of the *nix or 
Mac buildbots run tkinter and hence no tests that require a live tk window, and 
this one does.  Cheryl, what do you see on your linux?

Byte 0xc3 in position 1540 is the first byte of the utf-8 encoding of the 'ö' 
in Löwis on line 27 of CREDITS.txt.  So on your system, readline must be 
reading *and decoding* more of the file.

I am puzzled that the test fails now if it passed with the 3.6.4 release, as it 
and the textfile have not been touched since last summer.
The files are the same on all 3 python versions.

In any case, I will add encoding='utf-8'to open.  I will also use subtest to 
identify failing cases.  I will need you to verify the fix on your system.

--
nosy: +csabella
stage:  -> needs patch
type:  -> behavior
versions: +Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32826] idle test fails at least on the 3.6 branch

[Matthias Klose]

New submission from Matthias Klose :

seen with the 3.6 branch 20180212, last known succeeding test is the 3.6.4 
release.

test test_idle failed -- Traceback (most recent call last):
  File 
"/home/packages/python/3.6/python3.6-3.6.4/Lib/idlelib/idle_test/test_help_about.py",
 line 78, in test_file_buttons
self.assertEqual(f.readline().strip(), get('1.0', '1.end'))
  File 
"/home/packages/python/3.6/python3.6-3.6.4/build-debug/../Lib/encodings/ascii.py",
 line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1540: 
ordinal not in range(128)

--
assignee: terry.reedy
components: IDLE
messages: 312037
nosy: doko, terry.reedy
priority: normal
severity: normal
status: open
title: idle test fails at least on the 3.6 branch
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com