[issue32872] backport of #32305 causes regressions in various packages

Ned Deily added the comment: New changeset 7f554c536cfe2e66a1ff0a36c8896040be1e5aee by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-32872: Avoid regrtest compatibility issue with namespace packages. (GH-6276) (GH-6278)

[issue32872] backport of #32305 causes regressions in various packages

Change by Ned Deily : -- priority: release blocker -> resolution: -> fixed stage: patch review -> resolved status: open -> closed type: crash -> ___ Python tracker

[issue32872] backport of #32305 causes regressions in various packages

Ned Deily added the comment: New changeset a93662cf8fb98e41f2b7e7c032b680eee834d290 by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-32872: Avoid regrtest compatibility issue with namespace packages. (GH-6276) (GH-6278)

[issue32872] backport of #32305 causes regressions in various packages

Ned Deily added the comment: New changeset d2d5bd8bc4f58b572702d572dc8491f0a50144e6 by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-32872: Avoid regrtest compatibility issue with namespace packages. (GH-6276) (#6277)

[issue32872] backport of #32305 causes regressions in various packages

Change by miss-islington : -- pull_requests: +6005 ___ Python tracker ___

[issue32872] backport of #32305 causes regressions in various packages

Ned Deily added the comment: New changeset e52ac045972a4f75d7f52e4ee0d6de128259134d by Ned Deily in branch 'master': bpo-32872: Avoid regrtest compatibility issue with namespace packages. (GH-6276)

[issue32872] backport of #32305 causes regressions in various packages

Change by miss-islington : -- pull_requests: +6004 ___ Python tracker ___

[issue32872] backport of #32305 causes regressions in various packages

Change by Ned Deily : -- pull_requests: +6003 ___ Python tracker ___ ___ Python-bugs-list

[issue32872] backport of #32305 causes regressions in various packages

Matthias Klose added the comment: reopening. Lib/test/libregrtest/setup.py still needs fixing at least on 3.6, I didn't check the trunk. libregrtest/setup.py: 60c60 < if hasattr(module, '__file__'): --- > if getattr(module, '__file__', None): --

[issue32872] backport of #32305 causes regressions in various packages

Change by Barry A. Warsaw : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32872] backport of #32305 causes regressions in various packages

Change by Barry A. Warsaw : -- keywords: +patch pull_requests: +5682 stage: needs patch -> patch review ___ Python tracker ___

[issue32872] backport of #32305 causes regressions in various packages

Ned Deily added the comment: Thanks, Barry! I don't see that either action is ideal but I am concerned about breaking third-party packages and 2 (already known) breakages is worrisome. And thanks, @doko, for bringing the matter up. --

[issue32872] backport of #32305 causes regressions in various packages

Barry A. Warsaw added the comment: I'd personally prefer to keep the fix (I ran into some problems w/3.6), but I'll defer to the RM. I'll revert the change for 3.6, but I want to test it with importlib_resources first, since I'll probably have to spin a new release of that

[issue32872] backport of #32305 causes regressions in various packages

Ned Deily added the comment: OK, I agree with Brett and Nick. Barry, are you OK with reverting this change for 3.6? If so, can you do the honors? -- stage: -> needs patch ___ Python tracker

[issue32872] backport of #32305 causes regressions in various packages

Nick Coghlan added the comment: +1 from me for making the change 3.7.0+ only - 3.6 isn't doing the right thing, but given folks are relying on it doing the wrong thing, then let's leave it alone given where it is in its lifecycle. --

[issue32872] backport of #32305 causes regressions in various packages

Brett Cannon added the comment: I'm personally fine if the change gets reverted. I don't think the odd behaviour is severe enough to justify breaking projects in a maintenance release. Besides, they will learn soon enough about their code breaking in Python 3.7. --

[issue32872] backport of #32305 causes regressions in various packages

Change by Ned Deily : -- priority: critical -> release blocker ___ Python tracker ___ ___

[issue32872] backport of #32305 causes regressions in various packages

Ned Deily added the comment: Now that we know that this change *does* break some existing code, I think it is worth having that talk as mentioned in PR 5481: "I suppose it's possible that this will break existing code, but I'd argue that because current behavior runs counter

[issue32872] backport of #32305 causes regressions in various packages

Change by Barry A. Warsaw : -- resolution: -> wont fix stage: -> resolved status: open -> closed ___ Python tracker ___

[issue32872] backport of #32305 causes regressions in various packages

Barry A. Warsaw added the comment: Both of those upstreams should be using `if getattr(module, '__file__', None)` instead. The old behavior was an undocumented quirk. -- ___ Python tracker

[issue32872] backport of #32305 causes regressions in various packages

New submission from Matthias Klose : The backport of issue #32305 causes regressions in several packaged namespace packages: https://bugs.debian.org/890621 https://bugs.debian.org/890754 while the change is intended, is it appropriate to backport it to 3.6? Please could you