[issue32980] Remove functions that do nothing in _Py_InitializeCore()

Benjamin Peterson added the comment: New changeset 7023644e0c310a3006c984318c2c111c468735b4 by Benjamin Peterson (Thomas Nyberg) in branch 'master': closes bpo-32980 Remove _PyFrame_Init (GH-5965)

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

Thomas Nyberg added the comment: ince I originated this issue and I think I understand the concerns, I figured I could speed up the back and forth in this thread by opening this new PR which removes the `_PyFrame_Init()` function. I couldn't find any `_PyFrame_Fini()`

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

Change by Thomas Nyberg : -- pull_requests: +5732 ___ Python tracker ___ ___

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

Nick Coghlan added the comment: Yeah, dropping _PyFrame_Init/Fini for 3.8+ would make sense. It's PyByteArray_Init/Fini that probably aren't worth the hassle of removing, since the lack of a leading underscore means they'd need to go through a deprecation cycle.

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

Benjamin Peterson added the comment: Future maintainers of what exactly can expect these functions to be called? CPython? If we need to do initialization of frameobject.c later, we can simply add _PyFrame_Init back. We certainly don't support ELF-interposition of

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

Nick Coghlan added the comment: (Bringing my response from core-mentorship over to the main tracker) These APIs are exposed to embedding applications via the pylifecycle header: https://github.com/python/cpython/blob/master/Include/pylifecycle.h#L143 While we technically

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

Change by Brett Cannon : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

Change by Thomas Nyberg : -- keywords: +patch pull_requests: +5719 stage: -> patch review ___ Python tracker ___

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

New submission from Thomas Nyberg : The `_PyFrame_Init()` and `PyByteArray_Init()` functions are called in these two locations in the `_Py_InitializeCore()` function: https://github.com/python/cpython/blob/master/Python/pylifecycle.c#L693-L694