[issue33038] GzipFile doesn't always ignore None as filename

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33038] GzipFile doesn't always ignore None as filename

Serhiy Storchaka added the comment: New changeset afe5f633e49e0e873d42088ae56819609c803ba0 by Serhiy Storchaka (Bo Bayles) in branch '2.7': bpo-33038: Fix gzip.GzipFile for file objects with a non-string name attribute. (GH-6095)

[issue33038] GzipFile doesn't always ignore None as filename

Serhiy Storchaka added the comment: The workaround in the current 2.7 is specifying an explicit filename argument: with tempfile.SpooledTemporaryFile() as fd: with gzip.GzipFile(filename='', mode='wb', fileobj=fd) as gz: gz.write(b'asdf') --

[issue33038] GzipFile doesn't always ignore None as filename

bbayles added the comment: Is there someone who might be in a position to review the PR? It's pretty short. -- ___ Python tracker

[issue33038] GzipFile doesn't always ignore None as filename

Ned Deily added the comment: It looks like PR 6095 for this issue has not been reviewed or merged yet. The commits for v2.7.15 are here: https://github.com/python/cpython/commits/v2.7.15 -- nosy: +benjamin.peterson, ned.deily ___

[issue33038] GzipFile doesn't always ignore None as filename

Diego Argueta added the comment: Did this make it into 2.7.15? There aren't any release notes for it on the download page like usual. -- ___ Python tracker

[issue33038] GzipFile doesn't always ignore None as filename

Change by bbayles : -- pull_requests: +5857 stage: -> patch review ___ Python tracker ___

[issue33038] GzipFile doesn't always ignore None as filename

Diego Argueta added the comment: Yeah that's fine. Thanks! -- ___ Python tracker ___

[issue33038] GzipFile doesn't always ignore None as filename

bbayles added the comment: da, would you mind if I add a test and a news entry to your patch and submit it as a Github pull request? -- nosy: +bbayles ___ Python tracker

[issue33038] GzipFile doesn't always ignore None as filename

New submission from Diego Argueta : The Python documentation states that if the GzipFile can't determine a filename from `fileobj` it'll use an empty string and won't be included in the header. Unfortunately, this doesn't work for SpooledTemporaryFile which has a