[issue33061] NoReturn missing from __all__ in typing.py

[Ivan Levkivskyi]

Ivan Levkivskyi  added the comment:

The typing repo PR is not merged yet, but I am closing this here, the remainder 
is tracked in typing repo.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33061] NoReturn missing from __all__ in typing.py

[Ivan Levkivskyi]

Ivan Levkivskyi  added the comment:


New changeset ac5602746ed39ca6591e98e062e587121ac71371 by Ivan Levkivskyi in 
branch '3.7':
bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127) (#6162)
https://github.com/python/cpython/commit/ac5602746ed39ca6591e98e062e587121ac71371


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33061] NoReturn missing from __all__ in typing.py

[Ivan Levkivskyi]

Change by Ivan Levkivskyi :


--
pull_requests: +5918

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33061] NoReturn missing from __all__ in typing.py

[Ivan Levkivskyi]

Ivan Levkivskyi  added the comment:

I think it makes sense to also fix this in 3.7. I will prepare a backport now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33061] NoReturn missing from __all__ in typing.py

[Ivan Levkivskyi]

Ivan Levkivskyi  added the comment:


New changeset 4573820d2a9156346392838d455e89f33067e9dd by Ivan Levkivskyi 
(aetracht) in branch 'master':
bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127)
https://github.com/python/cpython/commit/4573820d2a9156346392838d455e89f33067e9dd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33061] NoReturn missing from __all__ in typing.py

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
pull_requests: +5889
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33061] NoReturn missing from __all__ in typing.py

[Guido van Rossum]

Guido van Rossum  added the comment:

Yes please! Updating __all__ is too easy to forget.

IIRC there are scripts that check for this but they are too strict.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33061] NoReturn missing from __all__ in typing.py

[Ivan Levkivskyi]

New submission from Ivan Levkivskyi :

This is clearly a bug. Would you like to make a PR?

--
nosy: +levkivskyi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33061] NoReturn missing from __all__ in typing.py

[Ivan Levkivskyi]

Change by Ivan Levkivskyi :


--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33061] NoReturn missing from __all__ in typing.py

[Allen Tracht]

Change by Allen Tracht :


--
components: Library (Lib)
nosy: Allen Tracht
priority: normal
severity: normal
status: open
title: NoReturn missing from __all__ in typing.py
type: behavior
versions: Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com