[issue33161] Refactor of pathlib's _WindowsBehavior.gethomedir

2018-08-03 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the PR, but we usually avoid unnecessary churn in Python codebase. Both versions look fine, and deciding which one to use is just a matter of personal taste. -- components: -Windows nosy: +berker.peksag -paul.moore, steve.dower,

[issue33161] Refactor of pathlib's _WindowsBehavior.gethomedir

2018-03-27 Thread Ekin Dursun
Change by Ekin Dursun : -- keywords: +patch pull_requests: +6002 stage: -> patch review ___ Python tracker ___

[issue33161] Refactor of pathlib's _WindowsBehavior.gethomedir

2018-03-27 Thread Ekin Dursun
New submission from Ekin Dursun : At line 245, default value for drv is provided with KeyError handling, but it is better to use dict's get method. -- components: Library (Lib), Windows messages: 314562 nosy: onlined, paul.moore, steve.dower, tim.golden, zach.ware