[issue33351] Support compiling with clang-cl on Windows

Change by Isuru Fernando : -- pull_requests: +17747 pull_request: https://github.com/python/cpython/pull/18371 ___ Python tracker ___

[issue33351] Support compiling with clang-cl on Windows

Gisle Vanem added the comment: I will add to this issue my *only* compile problem I had using clang-cl ver 9. It has an issue with parsing the `frame_t` structure in Modules/_tracemalloc.c: Modules/_tracemalloc.c(64,11): error: declaration of anonymous struct must be a definition typedef

[issue33351] Support compiling with clang-cl on Windows

Ethan Smith added the comment: I just updated the PR with some more information after trying this on every VS project. It seems that clang-cl still fails on some projects/tests, but I don't think that is a big problem. I was mostly interested in getting Python core to build with clang-cl,

[issue33351] Support compiling with clang-cl on Windows

Change by Ethan Smith : -- pull_requests: +7292 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33351] Support compiling with clang-cl on Windows

Ethan Smith added the comment: I sent my patches to clang-cl upstream [1]. It seems they want to implement Hardware Lock Elision (which is used by some MSVC compiler intrinsics in pyatomic.h) before implementing the needed intrinsics. I have found temporary replacements that do not elide

[issue33351] Support compiling with clang-cl on Windows

Ethan Smith added the comment: After wrangling with some missing compiler intrinsics, I've been able to get CPython to build with an almost vanilla clang-cl! I plan on upstreaming the patches to the LLVM project once I clean them up a bit. After that I will clean up the

[issue33351] Support compiling with clang-cl on Windows

Change by Ethan Smith : -- keywords: +patch pull_requests: +6448 stage: test needed -> patch review ___ Python tracker ___

[issue33351] Support compiling with clang-cl on Windows

Gregory P. Smith added the comment: FWIW, I would _love_ to see this. But I don't wrangle Windows myself so I can't usefully offer anything other than being happy to volunteer to run a Clang on Windows buildbot VM once there is something to actually be run. -- nosy:

[issue33351] Support compiling with clang-cl on Windows

Ethan Smith added the comment: > Feel free to start creating patches so we can get an idea of what the changes > would look like. Hopefully it's not that dramatic. Okay, will do. I have a few smaller patches to start with. Clang-cl tries to be as compatible as possible

[issue33351] Support compiling with clang-cl on Windows

Steve Dower added the comment: Feel free to start creating patches so we can get an idea of what the changes would look like. Hopefully it's not that dramatic. Be very careful making performance claims without benchmarks to back it up, and ideally against multiple

[issue33351] Support compiling with clang-cl on Windows

Change by Terry J. Reedy : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware stage: -> test needed ___ Python tracker

[issue33351] Support compiling with clang-cl on Windows

Ethan Smith added the comment: >* Are you suggesting that CPython's build system move away from MSVC as the >platform compiler for Windows? Not immediately, I don't think we should give up on the stability that currently exists with the cl based compilation. However, I

[issue33351] Support compiling with clang-cl on Windows

Alex Walters added the comment: When supporting platforms comes up, there's a usual list of questions, especially for windows. I can remember two of them off the top of my head: * Are you suggesting that CPython's build system move away from MSVC as the platform

[issue33351] Support compiling with clang-cl on Windows

Ethan Smith added the comment: No, this is provided from llvm.org. You can find it as e.g. "Clang for Windows (64-bit)" here: http://releases.llvm.org/download.html#6.0.0 The Clang/C2 in Visual Studio is very different, and deprecated anyway. --

[issue33351] Support compiling with clang-cl on Windows

Alex Walters added the comment: Is this the same as the clang/llvm C1 that you can enable from inside Visual Studio? -- nosy: +tritium ___ Python tracker

[issue33351] Support compiling with clang-cl on Windows

Change by pmpp : -- nosy: +pmpp ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue33351] Support compiling with clang-cl on Windows

New submission from Ethan Smith : The clang folks have been hard at work making an ABI compatible backend to clang for Windows. Additionally they have created a cl compatible driver for clang, which can be used in lieu of cl itself. Clang-cl has been adopted to build Chrome