[issue33375] warnings: get filename from frame.f_code.co_filename

STINNER Victor added the comment: I closed bpo-8787 as a duplicate of this issue. -- versions: +Python 3.8 ___ Python tracker ___

[issue33375] warnings: get filename from frame.f_code.co_filename

STINNER Victor added the comment: This change introduced a regression: bpo-33912 "[EASY] test_warnings: test_exec_filename() fails when run with -Werror". I consider that it's an easy issue, please don't fix it, but explain how to fix it and let a newcomer to fix it!

[issue33375] warnings: get filename from frame.f_code.co_filename

Brett Cannon added the comment: New changeset 3f45f5da8eb052f1b54d37086c67b7094f35b67b by Brett Cannon (Zackery Spytz) in branch 'master': bpo-33375: Fix GCC warning in Python/_warnings.c (GH-7556) https://github.com/python/cpython/commit/3f45f5da8eb052f1b54d37086c67b7094f35b67b --

[issue33375] warnings: get filename from frame.f_code.co_filename

Brett Cannon added the comment: Thanks everyone for making this happen! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33375] warnings: get filename from frame.f_code.co_filename

Change by Zackery Spytz : -- pull_requests: +7190 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33375] warnings: get filename from frame.f_code.co_filename

Brett Cannon added the comment: New changeset 11a896652ee98aa44e59ed25237f9efb56635dcf by Brett Cannon (Thomas Kluyver) in branch 'master': bpo-33375: Get filename for warnings from frame.f_code.co_filename (GH-6622)

[issue33375] warnings: get filename from frame.f_code.co_filename

Thomas Kluyver added the comment: Thanks! No rush, I just thought I'd take the opportunity when you added yourself to the nosy list. -- ___ Python tracker

[issue33375] warnings: get filename from frame.f_code.co_filename

Brett Cannon added the comment: I just added myself to review the PR. At worst I will get to it during the sprints at PyCon US. On Thu, 3 May 2018 at 12:52 Thomas Kluyver wrote: > > Thomas Kluyver added the comment: > > Hi

[issue33375] warnings: get filename from frame.f_code.co_filename

Thomas Kluyver added the comment: Hi Brett! If you get a moment, any review of the linked PR would be welcome. :-) https://github.com/python/cpython/pull/6622 -- ___ Python tracker

[issue33375] warnings: get filename from frame.f_code.co_filename

Change by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue33375] warnings: get filename from frame.f_code.co_filename

Change by Thomas Kluyver : -- keywords: +patch pull_requests: +6318 stage: -> patch review ___ Python tracker ___

[issue33375] warnings: get filename from frame.f_code.co_filename

New submission from Thomas Kluyver : The warnings module tries to find and show the line of code which is responsible for a warning, for the same reasons that tracebacks show a line of code from each stack frame. However, they work in quite different ways. Native