[issue33433] ipaddress is_private misleading for IPv4 mapped IPv6 addresses

[Gregory P. Smith]

Gregory P. Smith  added the comment:

thanks!

--
resolution:  -> fixed
stage: patch review -> commit review
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33433] ipaddress is_private misleading for IPv4 mapped IPv6 addresses

[miss-islington]

miss-islington  added the comment:


New changeset a44bb6ddb17538b7b2096d13eb79a1208bd97f34 by Miss Islington (bot) 
in branch '3.10':
bpo-33433 Fix private address checking for IPv4 mapped IPv6. (GH-26172)
https://github.com/python/cpython/commit/a44bb6ddb17538b7b2096d13eb79a1208bd97f34


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33433] ipaddress is_private misleading for IPv4 mapped IPv6 addresses

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +24806
pull_request: https://github.com/python/cpython/pull/26189

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33433] ipaddress is_private misleading for IPv4 mapped IPv6 addresses

[Gregory P. Smith]

Gregory P. Smith  added the comment:

Questionable as to if this counts as a bug or not, but I agree it is 
counter-intuitive given the purpose of actually checking the .is_private 
property of an address.  So updating the behavior makes sense, but I'll be 
conservative w.r.t. behavior changes and not apply this to a 3.9 or earlier.

--
nosy: +gregory.p.smith
type:  -> enhancement
versions: +Python 3.10, Python 3.11 -Python 3.4, Python 3.5, Python 3.6, Python 
3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33433] ipaddress is_private misleading for IPv4 mapped IPv6 addresses

[Pete Wicken]

Pete Wicken  added the comment:

I've opened a PR that should hopefully address this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33433] ipaddress is_private misleading for IPv4 mapped IPv6 addresses

[Pete Wicken]

Change by Pete Wicken :


--
keywords: +patch
pull_requests: +24799
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/26172

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33433] ipaddress is_private misleading for IPv4 mapped IPv6 addresses

[Pete Wicken]

Change by Pete Wicken :


--
nosy: +Wicken

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33433] ipaddress is_private misleading for IPv4 mapped IPv6 addresses

[Thomas Kriechbaumer]

New submission from Thomas Kriechbaumer :

ipaddress.IPv4Address and ipaddress.IPv6Address provide a is_private function 
that indicates if the address (or network) is part of a "private" IP range, as 
designated by the IANA special-use registry.

The current documentation is as follows:
> is_private
>True if the address is allocated for private networks. See 
> iana-ipv4-special-registry (for IPv4) or iana-ipv6-special-registry (for 
> IPv6).


However, IPv4-mapped IPv6 addresses are currently being reported as "private" 
by this function (see 
https://github.com/python/cpython/commit/22c31764262b02338265a059c738b8d24fd9a0e4#diff-0fc57874e463b95dbdfe6f80ae918ea1R1869).

I consider this a bug or at least counter-intuitive, because e.g. 
:::8.8.8.8 is most definitely NOT a private IP address, and yet the 
ipaddress.is_private function reports True.
The IANA special-use registry does not contain any references to "being 
private" for the :: region. It just designates it to be used for 
IPv4-mapped address.

--
components: Library (Lib)
messages: 316213
nosy: Thomas Kriechbaumer
priority: normal
severity: normal
status: open
title: ipaddress is_private misleading for IPv4 mapped IPv6 addresses
versions: Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com