[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-15 Thread Amber Brown

Amber Brown  added the comment:

This change mirrors the default in FieldStorage (which it calls). If it's not 
the best option, then it would need to be changed in FieldStorage too.

(personally, I don't like strict because UnicodeDecodeErrors on untrusted user 
input kind of sucks, but also replace is kind of broken as well.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Serhiy Storchaka

Serhiy Storchaka  added the comment:

Is 'replace' the good default value? 'strict' is the default value for most 
encoding/decoding operations. 'surrogateescape' is used if the failure and the 
loss of information are not desirable (like in filenames decoding). 
'backslashreplace' is good if we want to avoid a failure, but want to expose 
undecodable bytes in human-readable form.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Ned Deily

Ned Deily  added the comment:

Thanks for the report and the PR, @hawkowl!  Merged for 3.7.0rc1.

--
priority: release blocker -> 
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Ned Deily

Ned Deily  added the comment:


New changeset 5195039bb5529f1b18d30e8bfcabdee739912d76 by Ned Deily (Miss 
Islington (bot)) in branch '3.7':
bpo-33497: Add NEWS and ACKS entries. (GH-6838) (GH-6840)
https://github.com/python/cpython/commit/5195039bb5529f1b18d30e8bfcabdee739912d76


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Ned Deily

Ned Deily  added the comment:


New changeset e8f968dcde520160bea7c98d298e58128f9abaa4 by Ned Deily (Miss 
Islington (bot)) in branch '3.7':
bpo-33497: Add errors param to cgi.parse_multipart and make an encoding in 
FieldStorage use the given errors (GH-6804) (GH-6837)
https://github.com/python/cpython/commit/e8f968dcde520160bea7c98d298e58128f9abaa4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread miss-islington

Change by miss-islington :


--
pull_requests: +6521

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Ned Deily

Ned Deily  added the comment:


New changeset d063b84d9ee435e9ae981c18faccaff5562792c3 by Ned Deily in branch 
'master':
bpo-33497: Add NEWS and ACKS entries. (GH-6838)
https://github.com/python/cpython/commit/d063b84d9ee435e9ae981c18faccaff5562792c3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Ned Deily

Change by Ned Deily :


--
pull_requests: +6520

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread miss-islington

Change by miss-islington :


--
pull_requests: +6519

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Ned Deily

Ned Deily  added the comment:


New changeset 545c955be997efd6b3827b981024e6b9945d82d1 by Ned Deily (Amber 
Brown) in branch 'master':
bpo-33497: Add errors param to cgi.parse_multipart and make an encoding in 
FieldStorage use the given errors (GH-6804)
https://github.com/python/cpython/commit/545c955be997efd6b3827b981024e6b9945d82d1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Ned Deily

Change by Ned Deily :


--
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Amber Brown

Change by Amber Brown :


--
keywords: +patch
pull_requests: +6489
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Thomas Wouters

Change by Thomas Wouters :


--
nosy: +ned.deily
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33497] cgi.parse_multipart does not have an associated "errors" parameter with its "encoding" parameter

2018-05-14 Thread Amber Brown

New submission from Amber Brown :

Lack of this parameter means that you may get an exception (if the incoming 
data is an invalid encoding) you can not get around.

This causes Twisted to be unable to provide a compatible API on Python 3.7.

--
messages: 316510
nosy: hawkowl
priority: normal
severity: normal
status: open
title: cgi.parse_multipart does not have an associated "errors" parameter with 
its "encoding" parameter
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com