[issue33516] unittest.mock: Add __round__ to supported magicmock methods

[STINNER Victor]

STINNER Victor  added the comment:

Thank you Martijn Pieters for the feature request/bug report, and thanks John 
Reese for the implementation!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33516] unittest.mock: Add __round__ to supported magicmock methods

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 6c4fab0f4b95410a1a964a75dcdd953697eff089 by Victor Stinner (John 
Reese) in branch 'master':
bpo-33516: Add support for __round__ in MagicMock (GH-6880)
https://github.com/python/cpython/commit/6c4fab0f4b95410a1a964a75dcdd953697eff089


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33516] unittest.mock: Add __round__ to supported magicmock methods

[Terry J. Reedy]

Change by Terry J. Reedy :


--
nosy: +michael.foord
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33516] unittest.mock: Add __round__ to supported magicmock methods

[John Reese]

Change by John Reese :


--
nosy: +jreese, lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33516] unittest.mock: Add __round__ to supported magicmock methods

[John Reese]

Change by John Reese :


--
keywords: +patch
pull_requests: +6553
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33516] unittest.mock: Add __round__ to supported magicmock methods

[Martijn Pieters]

New submission from Martijn Pieters :

I notice that __trunc__, __floor__ and __ceil__ are supported methods for 
MagicMock, but __round__ (in the same grouping of numeric types emulation 
methods, see 
https://docs.python.org/3/reference/datamodel.html#object.__round__), is not.

Please add this to the mapping too.

--
components: Library (Lib)
messages: 316641
nosy: mjpieters
priority: normal
severity: normal
status: open
title: unittest.mock:  Add __round__ to supported magicmock methods
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com