[issue33538] Remove useless check in subprocess

2018-05-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is in PyImport_Cleanup() in Python/import.c. Search PyObject_SetItem(modules, name, Py_None). If you will run Python with the -v option you will see numerous messages "# cleanup[2] removing ..." emitted on stderr.

[issue33538] Remove useless check in subprocess

2018-05-17 Thread TaoQingyun
TaoQingyun <845767...@qq.com> added the comment: I can't find the reset code, could you give me a link? Thanks. -- ___ Python tracker ___

[issue33538] Remove useless check in subprocess

2018-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is reset to None at the interpreter shutdown stage. This check was added intentionally. -- nosy: +serhiy.storchaka resolution: -> not a bug stage: -> resolved status: open -> closed

[issue33538] Remove useless check in subprocess

2018-05-16 Thread TaoQingyun
New submission from TaoQingyun <845767...@qq.com>: diff --git a/Lib/subprocess.py b/Lib/subprocess.py index bafb501fcf..4a0bb33978 100644 --- a/Lib/subprocess.py +++ b/Lib/subprocess.py @@ -766,7 +766,7 @@ class Popen(object): ResourceWarning, source=self) # In case