[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

STINNER Victor added the comment: New changeset 1381bfe9776e64fed45935efbe42a7ee8298bd44 by Victor Stinner in branch '3.6': bpo-33540, socketserver: Add _block_on_close for tests (GH-7317) https://github.com/python/cpython/commit/1381bfe9776e64fed45935efbe42a7ee8298bd44 --

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

Change by STINNER Victor : -- pull_requests: +6946 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

STINNER Victor added the comment: New changeset 829fcd0612049b21a6d3802b3306705218255f6b by Victor Stinner in branch 'master': bpo-33540: Fix socketserver.ThreadingMixIn if block_on_close=False (GH-7310) https://github.com/python/cpython/commit/829fcd0612049b21a6d3802b3306705218255f6b -

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

STINNER Victor added the comment: New changeset 29ae9dc7c30b23055fdd39bec4c8f19a28392351 by Victor Stinner in branch '3.7': bpo-33540: Fix socketserver.ThreadingMixIn if block_on_close=False (GH-7309) https://github.com/python/cpython/commit/29ae9dc7c30b23055fdd39bec4c8f19a28392351

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

Change by STINNER Victor : -- pull_requests: +6942 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

Change by STINNER Victor : -- pull_requests: +6941 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

STINNER Victor added the comment: I added the block_on_close class attribute to Python 3.7 and master. I'm not really proud of it, but it's the price of the backward compatibility! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

miss-islington added the comment: New changeset fa286edbde9ed660d99628aea14ee3b824c2afe6 by Miss Islington (bot) in branch '3.7': bpo-33540: Add block_on_close attr to socketserver (GH-6911) https://github.com/python/cpython/commit/fa286edbde9ed660d99628aea14ee3b824c2afe6 -- nosy: +m

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

Change by miss-islington : -- pull_requests: +6722 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

STINNER Victor added the comment: New changeset 453bd0bc65b7ea6a18c43da69143ab10d54c0a35 by Victor Stinner in branch 'master': bpo-33540: Add block_on_close attr to socketserver (GH-6911) https://github.com/python/cpython/commit/453bd0bc65b7ea6a18c43da69143ab10d54c0a35 -- __

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

Ned Deily added the comment: It would be great if someone(s) could give PR 6911 a review, since it is a release blocker for 3.7.0rc1. Thanks! -- ___ Python tracker ___ __

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

Change by STINNER Victor : -- nosy: +christian.heimes, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

STINNER Victor added the comment: I consider that it's a regression, so I pick the release blocker priority. Sorry Ned! -- nosy: +ned.deily priority: normal -> release blocker ___ Python tracker

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

Change by STINNER Victor : -- keywords: +patch pull_requests: +6580 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue33540] socketserver: Add an opt-in option to get Python 3.6 behaviour on server_close()

New submission from STINNER Victor : bpo-31151 changed ForkingMixIn and bpo-31233 changed ThreadingMixIn to block on server_closer() for processes/threads. I propose to add a new opt-in option to get the Python 3.6 behaviour. The old behaviour was wrong, but I expect that some people rely on i