[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 99d37a0ee82c16f30a874c9b583d59a3844dc9c9 by Miss Islington (bot) 
in branch '3.9':
bpo-33610: Edit idlelib.codecontext (GH-23773) (GH-23775)
https://github.com/python/cpython/commit/99d37a0ee82c16f30a874c9b583d59a3844dc9c9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

miss-islington  added the comment:


New changeset 925f9987866703b0e7cfde341d23f19b832603cb by Miss Islington (bot) 
in branch '3.8':
bpo-33610: Edit idlelib.codecontext (GH-23773)
https://github.com/python/cpython/commit/925f9987866703b0e7cfde341d23f19b832603cb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

Change by miss-islington :


--
pull_requests: +22631
pull_request: https://github.com/python/cpython/pull/23775

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

Change by miss-islington :


--
pull_requests: +22630
pull_request: https://github.com/python/cpython/pull/23774

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 6f79e60b66dacefca147bdaa80eb37f936a72991 by Terry Jan Reedy in 
branch 'master':
bpo-33610: Edit idlelib.codecontext (GH-23773)
https://github.com/python/cpython/commit/6f79e60b66dacefca147bdaa80eb37f936a72991


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +22629
pull_request: https://github.com/python/cpython/pull/23773

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Delete E6.  No bug.  I do have a couple of internal edits.

--
dependencies:  -IDLE: Context lines not working correctly

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

E4. Max context lines = 0 is treated as infinity.  For depth 0, 
"self.info[-self.context_depth:]" is whole slice.  I don't remember if this is 
intended (if one does not want context, don't toggle it on), but it is not 
documented in settings help or doc section.  In any case,
  offset = max(1, lines - self.context_depth) - 1
fails with depth 0.

E5. test_codecontext is affected by user customization, but should not be.

E6. Bad bug make CC useless.  See #42638.

--
dependencies: +IDLE: Context lines not working correctly
versions: +Python 3.10 -Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

miss-islington  added the comment:


New changeset 28815e0e2c904644660d29995cdfbb65f67e4a1d by Miss Islington (bot) 
in branch '3.7':
bpo-33610: validate non-negative integer inputs in IDLE's config (GH-14822)
https://github.com/python/cpython/commit/28815e0e2c904644660d29995cdfbb65f67e4a1d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

miss-islington  added the comment:


New changeset 5dab5e7d24c790d54b8d1eca0568e798bfda2c68 by Miss Islington (bot) 
in branch '3.8':
bpo-33610: validate non-negative integer inputs in IDLE's config (GH-14822)
https://github.com/python/cpython/commit/5dab5e7d24c790d54b8d1eca0568e798bfda2c68


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

Change by miss-islington :


--
pull_requests: +14689
pull_request: https://github.com/python/cpython/pull/14913

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

Change by miss-islington :


--
pull_requests: +14690
pull_request: https://github.com/python/cpython/pull/14914

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Tal Einat]

Tal Einat  added the comment:


New changeset 1ebee37dde5c2aabc8e2d2c7bbe2a69b293133bb by Tal Einat in branch 
'master':
bpo-33610: validate non-negative integer inputs in IDLE's config (GH-14822)
https://github.com/python/cpython/commit/1ebee37dde5c2aabc8e2d2c7bbe2a69b293133bb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 86eb5daaf31860da479e034d69e9a6d4f47a8eb6 by Terry Jan Reedy (Miss 
Islington (bot)) in branch '3.8':
bpo-33610: IDLE's code-context always shows current context immediately 
(GH-14821) (#14846)
https://github.com/python/cpython/commit/86eb5daaf31860da479e034d69e9a6d4f47a8eb6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

miss-islington  added the comment:


New changeset db2957c8ebbe1c4609b3fc730c6e682cb8ccfeb0 by Miss Islington (bot) 
in branch '3.7':
bpo-33610: IDLE's code-context always shows current context immediately 
(GH-14821)
https://github.com/python/cpython/commit/db2957c8ebbe1c4609b3fc730c6e682cb8ccfeb0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

Change by miss-islington :


--
pull_requests: +14638
pull_request: https://github.com/python/cpython/pull/14847

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset e0a1f8fb5c60886dbddf1a3ccb5d47576bdd43e2 by Terry Jan Reedy (Tal 
Einat) in branch 'master':
bpo-33610: IDLE's code-context always shows current context immediately 
(GH-14821)
https://github.com/python/cpython/commit/e0a1f8fb5c60886dbddf1a3ccb5d47576bdd43e2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

Change by miss-islington :


--
pull_requests: +14637
pull_request: https://github.com/python/cpython/pull/14846

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Tal Einat]

Tal Einat  added the comment:

Regarding validating integer inputs in the configuration dialog (E3), see my 
new PR GH-14822.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Tal Einat]

Change by Tal Einat :


--
pull_requests: +14616
pull_request: https://github.com/python/cpython/pull/14822

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Tal Einat]

Tal Einat  added the comment:

Terry, on latest master (with the aforementioned PR merged), the context is 
updated quickly after the code-context is shown.  This happens after a delay of 
up to 100ms due to the update loop.

I've created PR GH-14821 with a fix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Tal Einat]

Change by Tal Einat :


--
keywords: +patch
pull_requests: +14615
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14821

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I2: replace font/hightlight loop with notification and immediate change instead 
of a delay is a bugfix.

In testing PR 14675 for #37530 I discovered a bug.  'Show' always shows a 
single blank line, as if the top visible line were the top line of the file.  
One should not have to scroll to trigger the context calculation.  This exists 
now, prior to the new PR. If/when we add a hotkey (M4), once should be able to 
show, see context, and hide just by hitting hotkey twice.  Add

C3: Make 'Show' show the context for the current top visible line.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

#37530 addresses I2, events (Tal, see msg319241 above).  I considered this to 
be about next in priority.  It also does some I1 cleanup.

In that list, the 2nd M3 should be M4.  The comment "D1 is PR 7579" should have 
referred to PR 7597, merged thereafter.

--
dependencies: +IDLE: simplify, optimize, and clean up code context
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

For M3 - #3.

--
dependencies: +IDLE: Gray out Code Context on non-editor windows

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

For M1 and M2 - #22703.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

D1 in issue35521.

--
dependencies: +IDLE: Add doc section for Code Conext

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

miss-islington  added the comment:


New changeset 08a1b133925f50903691c77fa9c23b618abc89f2 by Miss Islington (bot) 
in branch '3.6':
bpo-33610: Update IDLE Code Context doc entry (GH-7597)
https://github.com/python/cpython/commit/08a1b133925f50903691c77fa9c23b618abc89f2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

miss-islington  added the comment:


New changeset 2adfeef1853262b207a1993e523f0f3ba708dd9f by Miss Islington (bot) 
in branch '3.7':
bpo-33610: Update IDLE Code Context doc entry (GH-7597)
https://github.com/python/cpython/commit/2adfeef1853262b207a1993e523f0f3ba708dd9f


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

General Update: We have done 1, 3, 7, 8, 9, 11, 17, 21.  Very nice.  A 
re-organized list of the remainder (with old numbers).

Docs:
D1: idle.rst subsection on Code Context (19, see #33642).
D2: What's New in 3.6.6 and 3.7.0 (20).

Menu
M1: put Code Context and Zoom Height on same menu (5).
M2: Add Show/Hide Code Context (5).
M3. Gray out menu entry when not applicable (6).
M3: Shortcut for CC? (new),

Code Context Display
C1. Add vertical scrollbar if lines > maxlines (12).
C2. Add horizontal scrollbar if add to text (13).

Internal Changes
I1. Unspecified code cleanups for codecontext.py (2)
I2. Reduce events (4). Font change notification (15). Text active or text 
changed notification (16).

External Changes
E1. Mark blocks in editor (10, unlikely).
E2. Navigate by blocks in editor (14).
E3. Error check maxlines in configdialog (18).

D1 is PR 7579 and backports.  D2 was done on #33820 and #33821.

For M1, I would still like to move Zoom Height to Options with a separate bar 
after IDLE settings.

--
keywords: +3.5regression -patch
stage: patch review -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

Change by miss-islington :


--
pull_requests: +7220

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[miss-islington]

Change by miss-islington :


--
pull_requests: +7221

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset af4b0130d44bf8a1ff4f7b46195d1dc79add444a by Terry Jan Reedy in 
branch 'master':
 bpo-33610: Update IDLE Code Context doc entry (GH-7597)
https://github.com/python/cpython/commit/af4b0130d44bf8a1ff4f7b46195d1dc79add444a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +7219
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

Menu location:

If Code Context is moved under Windows, maybe Configure IDLE should be moved as 
well?  

- VS Code has Preferences under the File menu.
- Spyder has a menu option called Tools which contains Preferences, Update 
PYTHONPATH manager, and Reset Spyder to defaults
- Atom has Preferences under the Edit menu.
- Sublime Text has a menu called Preferences.
- Notepad++ has a menu called Settings, which includes Preferences.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

For item 11 - #33763

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Change by Cheryl Sabella :


--
dependencies: +IDLE: Use text widget for code context instead of label widget

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

After writing the above, I realized that line scroll only touches editor.py, 
not codecontext.py.  On the other hand, the next item, 8. jump to context line 
did have to wait.  Replacing Label with Text will require explicit height 
setting with each context change.  The click handler will be a simplified 
version of the scroll handler you just wrote.  Jumping to a line will look much 
better when it jumps to a whole rather than a fractional line.  Again, one of 
us should say something before starting.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I merged 'variable lines' and edited 'colors' to fix the resulting conflicts.  
Travis passed the latter so I expect to merge it also.  To avoid more 
conflicts, you should wait to create the 'alignment' branch until 'colors' is 
merged and pulled into your clone.  (We should continue to keep having two 
pending patches for the same file rare.)

Counter-argument for menu location.  Window has 1 to n top-level window items.  
Options will have just one item without Code Context.  So moving Zoom would 
make things more balanced.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

> That leaves line alignment.  If you are working on it, but don't have a PR 
> ready yet, please say so.

I was going to work on it this weekend, but haven't started yet.

I agree that moving Code Context to the Windows menu makes sense.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

19. idle.rst doc change
20. What's New for 3.6.6 and 3.7.0
These could be patches on this issue.
21. idlelib/NEWS.txt entries

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

18. Error or bounds checking for maxlines entry.  I believe this really a 
config dialog issue that applies to everything, but maxlines should be at least 
1, with some reasonable max.  In the meanwhile, we could check whether crazy 
entries (text, negatives, super high) can crash IDLE.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

5, reformulated. Now that 'Code Context' on the Options menu only toggles a 
feature for the current window, like 'Zoom Height' on the Window menu, both 
should appear together on the same menu.  My current inclination is to move 
'Code Context' to Window because a) it is the feature be that will be changed 
and discussed in What's New, and b) 'Window' otherwise lists individual windows 
so it more clearly implies that toggles are for the current window without 
adding a fake menu entry.  Agree?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The release candidate has been re-scheduled for June 11.  So we should be able 
to merge the minimal upgrade before that and get it in 3.7.0 and 3.6.6.  (The 
latter will come out at the same time as the former.)

Variable lines is about ready.  Colors looks like it should be, with a final 
test needed after variable lines is merged (or maybe I will reverse the order). 
 That leaves line alignment.  If you are working on it, but don't have a PR 
ready yet, please say so.

--
dependencies:  -IDLE: Configurable color on code context

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

For item 9 - #33679

--
dependencies: +IDLE: Configurable color on code context

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

While trying out variable lines, #33642, I encounter two related issues.

First is the context colors.  Black on gray is a variant of black on white.  I 
am using the dark theme, white on dark blue.  For fixed sized context, the high 
contrast is okay.  For variable context, having lines flip from light on dark 
to dark on light and back is distracting to obnoxious. So I want to change
9. Reenable user config of context colors?
to 
9. Reenable user config of context colors!
Add the current black on gray to the light theme and appropriate values, to be 
determined, to the dark theme.

Second is getting partial lines at the top of the text box as a result of 
scrolling with the mousewheel or scrollbar slider.  I never liked this but 
tolerated it.  With complete text lines above, it looks awful to me.  Hence, I 
consider the following to be a dependency of this issue.  
17. #33664 Scroll by lines instead of sometimes by pixels.

Following the implementation notes for #33664, once the label is changes to 
text, to get the target topline, 8. can be implemented with
text.xview_scroll(target_topline - current_topline, 'units')

I would like to release multiple user visible improvements at once, at least 7, 
9, and 17, so the new code context looks good from the start.   8, menu 
changes, and 14 could come later.

--
dependencies: +IDLE:  scroll text by lines, not pixels.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

For item 7 - #33642.

--
dependencies: +IDLE: Use variable number of lines in CodeContext

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

I've started looking at #22703, more specifically, I've been trying to recreate 
it.  Since the config changes in 3.6/3.7 where the flag was removed from config 
dialog, the code context needs to be turned on explicitly for each editor.  3.5 
has the old behavior.

So, I think the current change would be to add it back to config but with the 
behavior defined in #22703.  

I hope to have a PR within the next few days.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

With #33628 merged, I consider the next priorities to be 5. #22703 (overt bug, 
highest), 7, and 8, to make the feature more usable.

10. is a vague speculative feature that would use get_indent_firstword but 
would actually be for the editor.  Update problem: It requires a representation 
of the structure of the entire code, and any edit could change that.  The 
saving grace of code context is that it only maintains information about the 
invisible lines above the cursor.

More feasible than item 10 would be

14. Block structure navigation: As near as I can tell, Alt-arrowkey is 
currently the same as arrowkey.  Have Alt-Up and Alt-Down move to the next 
block line above or below with the same indent and Alt-Left, Alt-Right move up 
and out (smaller indent) or down and in (larger indent).

15. (Instead of 4b. One font loop for class.) Replace font loop with 
font-change notification by the editor when the editor gets such a notification 
(which is very rare).

16. (Instead of 4a. One font loop for class.)  The current loops update every 
window 10 times a second, which is about the upper limit for a great typist or 
normal scroller.  But only an active editor window needs updating, and there is 
at most 1.  Most checks are wasted.

16A. Replace update loop with notification of visible display changes.  Pro: We 
already monitor key and mouse actions.  Anti: the event loop is simple.

16B. Only run update loop in active window.  Anti: I don't think we currently 
monitor window focus.  Pro: if we don't, we will need to for a multipane, 
multitab IDLE.  (Stopping should be easy: check status before after call in 
callback.  This automatically does a last update after focus gone.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Cheryl Sabella]

Cheryl Sabella  added the comment:

For item 2 - #33628

--
dependencies: +IDLE: Code cleanup on codecontext

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Terry J. Reedy  added the comment:

11. Use read-only Text instead of Label for context. 
Text.index(f'@{e.x},{e.y}', where e is event, converts mouse click to line 
number.  That can be mapped to text line number for 8. above.  Text also enables

12. If context box is too short for all lines, add scrollbar.

13. When horizontal scrollbars are added to editor, scroll context along with 
text scroll.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33610] IDLE: Make multiple improvements to CodeContext

[Terry J. Reedy]

Change by Terry J. Reedy :


--
dependencies: +IDLE cond context: fix code update and font update timers, IDLE: 
Add docstrings and tests for codecontext, Idle Code Context: separate changing 
current and future editors
stage: test needed -> 
title: IDLE: Improve CodeContext (various issues) -> IDLE: Make multiple 
improvements to CodeContext
versions: +Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com