[issue33628] IDLE: Code cleanup on codecontext

2018-05-23 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33628] IDLE: Code cleanup on codecontext

2018-05-23 Thread miss-islington
miss-islington added the comment: New changeset b2ab5dc72b36d074a86f2b1d91ae804e5a7210f8 by Miss Islington (bot) in branch '3.7': bpo-33628: IDLE: Minor code cleanup of codecontext.py and its tests (GH-7085)

[issue33628] IDLE: Code cleanup on codecontext

2018-05-23 Thread miss-islington
miss-islington added the comment: New changeset 935c81bbbca28ca23862d7ee1f79cd502e447edd by Miss Islington (bot) in branch '3.6': bpo-33628: IDLE: Minor code cleanup of codecontext.py and its tests (GH-7085)

[issue33628] IDLE: Code cleanup on codecontext

2018-05-23 Thread miss-islington
Change by miss-islington : -- pull_requests: +6728 ___ Python tracker ___

[issue33628] IDLE: Code cleanup on codecontext

2018-05-23 Thread miss-islington
Change by miss-islington : -- pull_requests: +6727 ___ Python tracker ___

[issue33628] IDLE: Code cleanup on codecontext

2018-05-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 8506016f904ba6bc27bf5261f27a0bdd5945cd26 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-33628: IDLE: Minor code cleanup of codecontext.py and its tests (GH-7085)

[issue33628] IDLE: Code cleanup on codecontext

2018-05-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Super list. It made the diff really easy to parse into related changes. I printed it, reviewed code for items one by one, made a few changes, and checked them off when satisfied. IDLE *does* (sort of) allow tabs. One can read a file with

[issue33628] IDLE: Code cleanup on codecontext

2018-05-23 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +6718 stage: -> patch review ___ Python tracker ___

[issue33628] IDLE: Code cleanup on codecontext

2018-05-23 Thread Cheryl Sabella
New submission from Cheryl Sabella : Based on the github comments on PR5638, some code cleanup issues identified for codecontext. codecontext * getspacesfirstword - function and param1 name * get_line_info - make into helper function and change parm * get_context -