[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

STINNER Victor added the comment: The issue has been working around by increasing the timeout from 1 minute to 5 minutes. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6, Python 3.8 ___ Python

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

STINNER Victor added the comment: New changeset 8df4770e8d2c9ebd49c5e4d073eef3a5bc805cfc by Victor Stinner in branch '3.6': bpo-33716, test_concurrent_futures: increase timeout (GH-7828) (GH-8264) https://github.com/python/cpython/commit/8df4770e8d2c9ebd49c5e4d073eef3a5bc805cfc --

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

miss-islington added the comment: New changeset b89776fb1b000f73a62850bea78e5b3434bd7e9a by Miss Islington (bot) in branch '3.7': bpo-33716, test_concurrent_futures: increase timeout (GH-7828) https://github.com/python/cpython/commit/b89776fb1b000f73a62850bea78e5b3434bd7e9a --

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

Change by STINNER Victor : -- pull_requests: +7797 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

Change by miss-islington : -- pull_requests: +7796 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

Pablo Galindo Salgado added the comment: New changeset 3ad8decd76c736f393755537aeb19b5612c21761 by Pablo Galindo in branch 'master': bpo-33716, test_concurrent_futures: increase timeout (GH-7828) https://github.com/python/cpython/commit/3ad8decd76c736f393755537aeb19b5612c21761 --

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

Antoine Pitrou added the comment: I don't remember :-/ It's probably ok to increase the timeout, though. -- ___ Python tracker ___

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

STINNER Victor added the comment: +def tearDown(self): +self.executor.shutdown(wait=True) +dt = time.time() - self.t1 +if test.support.verbose: +print("%.2fs" % dt, end=' ') +self.assertLess(dt, 60, "synchronization issue: test lasted too long")

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +7436 stage: -> patch review ___ Python tracker ___ ___

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

STINNER Victor added the comment: Recent failure (fail then pass): http://buildbot.python.org/all/#/builders/58/builds/1031 == FAIL: test_crash (test.test_concurrent_futures.ProcessPoolSpawnExecutorDeadlockTest)

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

STINNER Victor added the comment: Hum, I guess that the fix is to use a timeout of 5 minutes instead of 1 minute. It's ok if the buildbot is slow. Moreover, it would be interesting to replace time.time() with time.monotonic(). -- ___ Python

[issue33716] test_concurrent_futures.test_crash() failed on x86 Windows7 3.7

New submission from STINNER Victor : x86 Windows7 3.7: http://buildbot.python.org/all/#/builders/111/builds/299 test_crash (test.test_concurrent_futures.ProcessPoolSpawnExecutorDeadlockTest) ... 26.57s ok ... test_crash (test.test_concurrent_futures.ProcessPoolSpawnExecutorDeadlockTest) ...