[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

STINNER Victor added the comment: Note: Python 2.7 doesn't have the test_discovery_from_dotted_namespace_packages() test, so no backport to 2.7 is needed. -- nosy: +vstinner ___ Python tracker

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

Ned Deily added the comment: Backported for 3.7.0rc1 and 3.6.6rc1. Thanks, all! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

Ned Deily added the comment: New changeset 040d4a7b5899b9635c6997c5ecb91f8299f0b352 by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-33748: fix tests altering sys.path and sys.modules (GH-7433) (GH-7603)

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

Ned Deily added the comment: New changeset 298eb07faa66da9c588bd82db14a6eef64167ede by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-33748: fix tests altering sys.path and sys.modules (GH-7433) (#7604) https://github.com/python/cpython/commit/298eb07faa66da9c588bd82db14a6eef64167ede

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

Change by miss-islington : -- pull_requests: +7226 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

Change by miss-islington : -- pull_requests: +7225 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

Tal Einat added the comment: New changeset 4ab4695388fb9ec03a14d93e90ce50d832a920ec by Tal Einat in branch 'master': bpo-33748: fix tests altering sys.path and sys.modules (GH-7433) https://github.com/python/cpython/commit/4ab4695388fb9ec03a14d93e90ce50d832a920ec --

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

Change by Tal Einat : -- keywords: +patch pull_requests: +7059 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

Serhiy Storchaka added the comment: Yes, and there are helpers in test.support and test.test_importlib.util. -- ___ Python tracker ___

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

Tal Einat added the comment: It seems that adding a directory to sys.path is the intended behavior of `loader.discover()`. Should the test be restoring sys.path back to it original value when it's done? Also, shouldn't this test (and some others) be restoring sys.modules when they're done?

[issue33748] test_discovery_failed_discovery in test_unittest modifies sys.path

New submission from Serhiy Storchaka : $ ./python -m test -v -m test_discovery_failed_discovery test_unittest ... Warning -- sys.path was modified by test_unittest Before: (139720094056760, ['/home/serhiy/py/cpython', '/usr/local/lib/python38.zip', '/home/serhiy/py/cpython/Lib',