[issue33750] Failed separate test_from_tuple in test_decimal

Stefan Krah added the comment: OK, thanks for checking the other tests! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33750] Failed separate test_from_tuple in test_decimal

Stefan Krah added the comment: New changeset bdab3ea8b98db2133ef1e2d92b2a2c539f08ddaf by Stefan Krah (Miss Islington (bot)) in branch '3.7': bpo-33750: Reset thread-local context precision in test_round(). (GH-7355) (#7357)

[issue33750] Failed separate test_from_tuple in test_decimal

Stefan Krah added the comment: New changeset 7f1bcda9bc3c04100cb047373732db0eba00e581 by Stefan Krah (Miss Islington (bot)) in branch '3.6': bpo-33750: Reset thread-local context precision in test_round(). (GH-7355) (#7356)

[issue33750] Failed separate test_from_tuple in test_decimal

Change by miss-islington : -- pull_requests: +6984 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33750] Failed separate test_from_tuple in test_decimal

Change by miss-islington : -- pull_requests: +6983 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33750] Failed separate test_from_tuple in test_decimal

Stefan Krah added the comment: New changeset e95dfc5006d19e59c7871faa9973356844ddb3ae by Stefan Krah in branch 'master': bpo-33750: Reset thread-local context precision in test_round(). (#7355) https://github.com/python/cpython/commit/e95dfc5006d19e59c7871faa9973356844ddb3ae --

[issue33750] Failed separate test_from_tuple in test_decimal

Serhiy Storchaka added the comment: I ran all tests separately and this was the only case. PR 7355 fixes it. There are no other failures, errors or warnings. ./python -m test -uall --list-cases test_decimal | xargs -n1 -I '{}' ./python -We -m test -vuall -m '{}' test_decimal --

[issue33750] Failed separate test_from_tuple in test_decimal

Stefan Krah added the comment: The thread local context was modified in test_round(), so prec=28 was used in test_from_tuple() when running the whole test suite but prec=9 when running the single test. I don't really consider that a bug, but it is easy to "fix". I wouldn't be surprised if

[issue33750] Failed separate test_from_tuple in test_decimal

Change by Stefan Krah : -- keywords: +patch pull_requests: +6982 stage: -> patch review ___ Python tracker ___ ___

[issue33750] Failed separate test_from_tuple in test_decimal

Stefan Krah added the comment: The test is insignificant. The real tests are mpdecimal-testit- 2.4.1.tar.gz (http://www.bytereef.org/mpdecimal/download.html), deccheck.py and my private python test suite. This test uses the global context that has been modified somewhere. I think I added

[issue33750] Failed separate test_from_tuple in test_decimal

Serhiy Storchaka added the comment: Doesn't this mean that the test is incorrect? It expects the result be '-0E-126', but actually it should be '-0E-107', and it is '-0E-126' only after performing some actions outside of the test. Or maybe that there is a leak of the state out

[issue33750] Failed separate test_from_tuple in test_decimal

Stefan Krah added the comment: I think the tests are order-dependent in multiple places. Personally, I don't see much value in fixing that because it has little effect on the actual code. -- ___ Python tracker

[issue33750] Failed separate test_from_tuple in test_decimal

New submission from Serhiy Storchaka : $ ./python -m test -v -m test_from_tuple test_decimal ... test_from_tuple (test.test_decimal.CWhitebox) ... FAIL == FAIL: test_from_tuple (test.test_decimal.CWhitebox)