[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Change by Tal Einat : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Change by Tal Einat : -- resolution: -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

miss-islington added the comment: New changeset 2474cef34cd50e603c674c4856a17e3da4af71b3 by Miss Islington (bot) in branch '3.6': bpo-33839: refactor IDLE's tooltips & calltips, add docstrings and tests (GH-7683)

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

miss-islington added the comment: New changeset e65ec491fbaa14db61a6559eb269733616b0e7f0 by Miss Islington (bot) in branch '3.7': bpo-33839: refactor IDLE's tooltips & calltips, add docstrings and tests (GH-7683)

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Change by miss-islington : -- pull_requests: +8170 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Change by miss-islington : -- pull_requests: +8171 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Tal Einat added the comment: New changeset 87e59ac11ee074b0dc1bc864c74fac0660b27f6e by Tal Einat in branch 'master': bpo-33839: refactor IDLE's tooltips & calltips, add docstrings and tests (GH-7683) https://github.com/python/cpython/commit/87e59ac11ee074b0dc1bc864c74fac0660b27f6e

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Tal Einat added the comment: >> If so, should it be possible for two tooltips to be shown at once, one for >> the mouse hover and one for the keyboard focus? > If we have different popup contents, I think 1 at a time would be fine. Consider the following example: A window with two buttons,

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Terry J. Reedy added the comment: > if: versus try: The latter is faster if try: succeeds. On the other hand, we > could make the if: fail by mocking it. Since there is no except: or else: > code to test, it hardly seems worth it. A low priority item. Generalizing 'show calltip': Great

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Tal Einat added the comment: > I just merged 2nd PR for #33907. I've merged master into the PR branch for this issue and fixed the merge issues. -- ___ Python tracker ___

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Tal Einat added the comment: > I [...] would like the popups to respond keyboard (Tab) focus changes as well > as mouse movement focus changes. Should tooltips also be shown automatically when the keyboard focus is on a widget? Using the same delay as for the mouse hover, perhaps? I've

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Tal Einat added the comment: >> TclError from widget.destroy suggests that we *might* be able to cleanup >> better. > Any suggestions for a better cleanup mechanism? (Following up my own question with another question...) Would it be better to check self.winfo_exists() instead of the

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Terry J. Reedy added the comment: I just merged 2nd PR for #33907. Combined effect is that module calltips and its class CallTips are now calltip and Calltip. In module calltip_w class CallTip is now CalltipWindow. -- ___ Python tracker

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Terry J. Reedy added the comment: I am going to change calltips.py and CallTips to calltip.py and Calltip in #33907, but will not change tooltip.py there as I would expect a merge conflict. Once the change is made elsewhere, change should be made to tooltip and test_tooltip directly.

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Tal Einat added the comment: > What do you think of changing 'ToolTip' to 'Tooltip'? +1, I'll change it. > TclError from widget.destroy suggests that we *might* be able to cleanup > better. The try/except clauses which are hard to test are used since the order in which widgets are

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Terry J. Reedy added the comment: As I mentioned elsewhere, I can a) imagine using this with dialogs to pop up hints about the particular entry widget, and b) would like the popups to respond keyboard (Tab) focus changes as well as mouse movement focus changes. Looking at the config

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Terry J. Reedy added the comment: What do you think of changing 'ToolTip' to 'Tooltip'? The me, the extra 'T' is over-aggressive camel-casing that impedes rather than aids reading. test_tooltip.py was missing the unittest invocation at the end, so I could not the tests from an editor.

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Tal Einat added the comment: Attaching coverage report for tooltip.py. The uncovered lines are required to avoid exceptions when closing a windows with a tooltip shown. These are not currently reproduced by test_tooltip.py because my attempts to exercise them in automated tests have all

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Tal Einat added the comment: The refactoring is done, manual testing with the htests works, and I've added automated tests with ~92% code coverage. Terry, I'd be happy for your review! -- ___ Python tracker

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Change by Tal Einat : -- keywords: +patch pull_requests: +7296 stage: test needed -> patch review ___ Python tracker ___ ___

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Change by Terry J. Reedy : -- Removed message: https://bugs.python.org/msg319406 ___ Python tracker ___ ___ Python-bugs-list

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Terry J. Reedy added the comment: I just ran the 3.7.0rc1 installer and here is no option to omit ctypes. -- ___ Python tracker ___

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

Tal Einat added the comment: I've started work on this. My progress can be followed on the bpo-33839 branch on my GitHub repo: https://github.com/taleinat/cpython/tree/bpo-33839 -- ___ Python tracker

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

New submission from Terry J. Reedy : calltip_w.py code is partly based on tooltip.py. The latter is currently unused. But it is needed, with changes, for squeezer (#1529353). So I would like to see if we can make an improved Tooltip class that can be used or subclassed by both. The