[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Ned Deily added the comment: Fixed in 3.7.0. Thanks, everyone! -- priority: release blocker -> resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Ned Deily added the comment: New changeset 235d0fb93cb456701ce24fad2bc307e9f0312d73 by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-33851: Fix ast.get_docstring() for a node that lacks a docstring. (GH-7682)

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Marius Gedminas added the comment: I've ran my findimports testsuite with CPython's git commit a50b825c18a92655f3dd7939e793fa3d4440d886 and my tests passed, so yes. -- ___ Python tracker

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Ned Deily added the comment: @mgedmin, Just to be certain, are you able to verify that the change in PR 7701 fixes the problem you see with 3.7.0rc1? -- ___ Python tracker

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Change by Serhiy Storchaka : -- assignee: -> ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

miss-islington added the comment: New changeset a50b825c18a92655f3dd7939e793fa3d4440d886 by Miss Islington (bot) in branch '3.7': bpo-33851: Fix ast.get_docstring() for a node that lacks a docstring. (GH-7682) https://github.com/python/cpython/commit/a50b825c18a92655f3dd7939e793fa3d4440d886

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Change by miss-islington : -- pull_requests: +7317 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Serhiy Storchaka added the comment: New changeset 08f127a3cad8ce4eb281d30d9488c91b0fd7cfed by Serhiy Storchaka in branch 'master': bpo-33851: Fix ast.get_docstring() for a node that lacks a docstring. (GH-7682) https://github.com/python/cpython/commit/08f127a3cad8ce4eb281d30d9488c91b0fd7cfed

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Change by Serhiy Storchaka : -- nosy: +inada.naoki ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Serhiy Storchaka added the comment: I think this fix is worth cherry-picking in 3.7.0. -- nosy: +ned.deily, serhiy.storchaka priority: normal -> release blocker versions: +Python 3.8 ___ Python tracker

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +7294 stage: -> patch review ___ Python tracker ___ ___

[issue33851] 3.7 regression: ast.get_docstring() for a node that lacks a docstring

New submission from Marius Gedminas : Python 3.7 removes an isinstance(node.body[0], Expr) check ast.get_docstring() that makes it crash when you pass in AST nodes of modules or functions that do not have docstrings. Steps to reproduce: - git clone https://github.com/mgedmin/findimports -