[issue33896] Document what components make up the filecmp.cmp os.stat signature.

[Ned Deily]

Change by Ned Deily :


--
resolution:  -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder:  -> filecmp.cmp(shallow=True) isn't actually shallow when only 
mtime differs
versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.7, Python 
3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33896] Document what components make up the filecmp.cmp os.stat signature.

[Andrei Kulakov]

Andrei Kulakov  added the comment:

Can be closed as a dupe of https://bugs.python.org/issue42958, which has a PR 
ready for review.

--
nosy: +andrei.avk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33896] Document what components make up the filecmp.cmp os.stat signature.

[Stavros Macrakis]

Stavros Macrakis  added the comment:

I agree completely that the documentation should be more explicit. The concept 
of "os.stat signature" is not defined anywhere as far as I can tell. The naive 
reader (like me) might mistakenly assume that the "os.stat signature" is a 
"digital signature" (i.e. a hash) of all of os.stat, and in particular that it 
includes the st_ino.

I would suggest that the documentation be updated to read "If shallow is true, 
files with the same length, modification time, and mode are taken to be equal."

--
nosy: +macrakis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33896] Document what components make up the filecmp.cmp os.stat signature.

[Cheryl Sabella]

Change by Cheryl Sabella :


--
assignee:  -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33896] Document what components make up the filecmp.cmp os.stat signature.

[R. David Murray]

R. David Murray  added the comment:

I think it might be OK to document what goes in to the signature, but probably 
in a footnote, as it is somewhat of an implementation detail and could 
conceivably change.  We could then also add a caution about mtime imprecision 
being a particular risk on some file systems.  I wouldn't want to put such a 
caution in the main doc paragraphs, but in a footnote I think it would be OK.

--
resolution: rejected -> 
stage: resolved -> needs patch
status: closed -> open
title: filecmp.cmp returns True on files that differ -> Document what 
components make up the filecmp.cmp os.stat signature.
versions: +Python 3.8 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33896] Document what components make up the filecmp.cmp os.stat signature.

[R. David Murray]

Change by R. David Murray :


--
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com