[issue34125] Profiling depends on whether **kwargs is given

[Robert Collins]

Robert Collins  added the comment:


New changeset b892d3ea468101d35e2fb081002fa693bd86eca9 by Robert Collins 
(Jeroen Demeyer) in branch 'master':
bpo-36994: add test for profiling method_descriptor with **kwargs (GH-13461)
https://github.com/python/cpython/commit/b892d3ea468101d35e2fb081002fa693bd86eca9


--
nosy: +rbcollins

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34125] Profiling depends on whether **kwargs is given

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

This is missing a testcase: PR 13461

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34125] Profiling depends on whether **kwargs is given

[Jeroen Demeyer]

Change by Jeroen Demeyer :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34125] Profiling depends on whether **kwargs is given

[miss-islington]

miss-islington  added the comment:


New changeset e89de7398718f6e68848b6340830aeb90b7d582c by Miss Islington (bot) 
(jdemeyer) in branch 'master':
bpo-34125: Enable profiling of method_descriptor in all cases (GH-8416)
https://github.com/python/cpython/commit/e89de7398718f6e68848b6340830aeb90b7d582c


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34125] Profiling depends on whether **kwargs is given

[STINNER Victor]

STINNER Victor  added the comment:

I opened a wider discussion: bpo-29502. The discussion didn't go anywhere yet.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34125] Profiling depends on whether **kwargs is given

[Jeroen Demeyer]

Change by Jeroen Demeyer :


--
keywords: +patch
pull_requests: +7942
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34125] Profiling depends on whether **kwargs is given

[Jeroen Demeyer]

New submission from Jeroen Demeyer :

Enable profiling for C functions:

>>> def prof(frame, typ, arg):
... if typ.startswith("c_"):
... print(arg, typ)
>>> import sys; sys.setprofile(prof)

and notice how profiling depends on **kwargs:

>>> list.append([], None)
 c_call
 c_return

>>> list.append([], None, **{})

There is no specification of what should be profiled and what not, so it's not 
clear what is the "correct" behavior. For the record: in Python 3.6, neither of 
these were profiled.

--
components: Interpreter Core
messages: 321746
nosy: jdemeyer
priority: normal
severity: normal
status: open
title: Profiling depends on whether **kwargs is given
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com