[issue34195] test_nt_helpers fails with case difference in drive letter

Tim Golden added the comment: New changeset ff64add8d4be2e37c552ba702f629b0b6639cd33 by Tim Golden in branch 'master': bpo-34195: Fix case-sensitive comparison in test_nt_helpers (GH-8448) https://github.com/python/cpython/commit/ff64add8d4be2e37c552ba702f629b0b6639cd33 --

[issue34195] test_nt_helpers fails with case difference in drive letter

Tim Golden added the comment: Test fixed to ignore case and volume differences between paths -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34195] test_nt_helpers fails with case difference in drive letter

Change by Tim Golden : -- keywords: +patch pull_requests: +7970 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue34195] test_nt_helpers fails with case difference in drive letter

Eryk Sun added the comment: > the directory in which I'm building (c:\work-in-progress) is actually > a junction to c:\users\\work-in-progress That makes sense. GetVolumePathName traverses backwards from the final component. If it reaches a reparse point (other than a junction that targets

[issue34195] test_nt_helpers fails with case difference in drive letter

Tim Golden added the comment: I think I've got down to the determining factor. For info: PYTHONHOME has nothing to do with it: the same thing happens if I cd into PCBuild\win32 and run python_d.exe directly For historical reasons the directory in which I'm building (c:\work-in-progress) is

[issue34195] test_nt_helpers fails with case difference in drive letter

Tim Golden added the comment: @eryksun almost idly I ran your ctypes code in the built interpreter. As written, it produces a lower-case c:\\ as yours did. But... Running Debug|Win32 interpreter... Python 3.8.0a0 (heads/master:7a3056f, Jul 23 2018, 08:23:33) [MSC v.1912 32 bit (Intel)] on

[issue34195] test_nt_helpers fails with case difference in drive letter

Tim Golden added the comment: Thanks, @eryksun. Whatever the reason, it's consistently failing in the way I describe. A case-insensitive test is obviously good for that and for the other reasons you give, so I'll patch the test anyway. -- ___

[issue34195] test_nt_helpers fails with case difference in drive letter

Eryk Sun added the comment: os__getvolumepathname_impl in Modules/posixmodule.c doesn't directly modify the case. So that leaves WinAPI GetVolumePathNameW as the culprit, but, according to the following test, apparently not in Windows 10.0.17134: kernel32 = ctypes.WinDLL('kernel32',

[issue34195] test_nt_helpers fails with case difference in drive letter

Tim Golden added the comment: import nt, sys; assert sys.executable.startswith(nt._getvolumepathname(sys.executable)) This code fails only when run from the python.bat as created by pcbuild\build.bat. The obvious difference is that the batch file sets PYTHONHOME which, presumably, is used

[issue34195] test_nt_helpers fails with case difference in drive letter

New submission from Tim Golden : >From a fresh build on Win10 with VS2017: python -munittest -v test.test_ntpath.TestNtpath.test_nt_helpers gives the following error: == FAIL: test_nt_helpers (test.test_ntpath.TestNtpath)