[issue34204] Bump the default pickle protocol in shelve

Change by Cheryl Sabella : -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34204] Bump the default pickle protocol in shelve

miss-islington added the comment: New changeset df59273c7a384ea8c890fa8e9b80c92825df841c by Zackery Spytz in branch 'master': bpo-34204: Use pickle.DEFAULT_PROTOCOL in shelve (GH-19639) https://github.com/python/cpython/commit/df59273c7a384ea8c890fa8e9b80c92825df841c -- nosy:

[issue34204] Bump the default pickle protocol in shelve

Zackery Spytz added the comment: It has not been abandoned. -- versions: +Python 3.10 -Python 3.8 ___ Python tracker ___ ___

[issue34204] Bump the default pickle protocol in shelve

Marco Castelluccio added the comment: I've opened https://github.com/python/cpython/pull/22751 to fix this, I know there was already a PR, but it seems to have been abandoned. -- ___ Python tracker

[issue34204] Bump the default pickle protocol in shelve

Change by Marco Castelluccio : -- nosy: +marco-c nosy_count: 6.0 -> 7.0 pull_requests: +21928 pull_request: https://github.com/python/cpython/pull/22751 ___ Python tracker ___

[issue34204] Bump the default pickle protocol in shelve

STINNER Victor added the comment: I wrote a short script to see the impact of file size depending on the protocol: --- import shelve import os.path print("== Short value ==") for proto in (0, 1, 2, 3, 4, 5): filename = 'shelve-picklev%s' % proto with shelve.open(filename,

[issue34204] Bump the default pickle protocol in shelve

Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 4.0 -> 5.0 pull_requests: +18963 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19639 ___ Python tracker

[issue34204] Bump the default pickle protocol in shelve

Change by Antoine Pitrou : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34204] Bump the default pickle protocol in shelve

New submission from Serhiy Storchaka : The default pickle protocol is 4 now. But shelve still uses the pickle protocol 3. Shouldn't it be bumped? Shouldn't shelve use pickle.DEFAULT_PROTOCOL by default? Disadvantages: 1. This will make shelve files incompatible with Python 3.3 by default.