[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

STINNER Victor added the comment: On my PR, Nick Coghlan wrote: "We may want to tweak the porting note in What's New, as I believe this may read more environment variables at init time than the interpreter did previously, so embedding applications that want more complete control may now

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

STINNER Victor added the comment: New changeset 0c90d6f75931da4fec84d06c2efe9dd94bb96b77 by Victor Stinner in branch '3.7': [3.7] bpo-34247: Fix Python 3.7 initialization (#8659) https://github.com/python/cpython/commit/0c90d6f75931da4fec84d06c2efe9dd94bb96b77 --

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Ronald Oussoren added the comment: The PR works for me as well, and looks ok to me. -- ___ Python tracker ___ ___ Python-bugs-list

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

STINNER Victor added the comment: I tested manually attached t.c with PR 8659: I get optimize=2 as expected. Full output: sys.flags(debug=0, inspect=0, interactive=0, optimize=2, dont_write_bytecode=0, no_user_site=0, no_site=0, ignore_environment=0, verbose=0, bytes_warning=0, quiet=0,

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

STINNER Victor added the comment: I first proposed to backport all code from master: https://mail.python.org/pipermail/python-dev/2018-July/154882.html But I'm not sure that it's a good idea, since I made *many* changes in the master branch since 3.7... I even added more files, and the

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Change by STINNER Victor : -- pull_requests: +8153 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Nick Coghlan added the comment: I believe Victor is at the EuroPython sprints as well, so if I'm right about that, I think the best option would be for the two of you to work out a resolution for 3.7.1 in person that at least keeps the test suites reasonably consistent, even if the

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Ronald Oussoren added the comment: I've created a pull request that seems to work properly, although I am not entirely sure that this is the right way to fix this. As I mentioned in the pull request I created it against the 3.7 branch because of bpo-34170, but would happily rebase it for

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Change by Ronald Oussoren : -- keywords: +patch pull_requests: +8037 stage: -> patch review ___ Python tracker ___ ___

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Ronald Oussoren added the comment: Interesting... pylifecycle.c uses code in main.c, I hadn't expected that. If I've read the code correctly Py_Initialize won't look at PYTHONOPTIMZE at all (and other environment variables that have a command-line equivalent). Those are read in

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Ronald Oussoren added the comment: FYI: I've filed issue34255 while working on this, test_embed assumes that you're building in the source directory (which I usually don't do). -- ___ Python tracker

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Ronald Oussoren added the comment: I'm at the EuroPython sprints and currently working on a testcase for this. Should be a nice way to get back into actively contributing to CPython :-) -- ___ Python tracker

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Nick Coghlan added the comment: This seems closely related to the work Victor is already pursuing to resolve bpo-34170 for Python 3.8 (e.g. https://github.com/python/cpython/commit/56b29b6d6fa3eb32bb1533ee3f21b1e7135648a0 ). The bpo-34170 changes are more invasive than we'd like for a

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Nick Coghlan added the comment: Next steps: - add a test case that runs the same sys.flags checks as in https://github.com/python/cpython/commit/d7ac06126db86f76ba92cbca4cb702852a321f78, but as a test_embed embedding test using Py_Initialize rather than Py_Main - create a shared internal

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Nick Coghlan added the comment: Ned, I think we should consider this a release blocker for 3.7.1 -- nosy: +ned.deily priority: normal -> release blocker ___ Python tracker

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Nick Coghlan added the comment: Comparing to Python 3.6, we can see that the code to update the C global flags from the environment variables used to live directly in _PyInitializeEx_Private:

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Nick Coghlan added the comment: Ah, wait - I see a relevant difference: the test case for issue31845 uses Py_Main, *not* Py_Initialize (since it's a command line test, not an embedding test). That means it's currently possible for the sequence of operations in

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Nick Coghlan added the comment: This feels like a duplicate of https://bugs.python.org/issue31845 (see https://github.com/python/cpython/commit/d7ac06126db86f76ba92cbca4cb702852a321f78 ) Is this definitely with the 3.7.0 release, or is it potentially with one of the earlier alphas before

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Change by Serhiy Storchaka : -- nosy: +brett.cannon, eric.snow, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Change by Ronald Oussoren : Added file: https://bugs.python.org/file47717/foo.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

Change by Ronald Oussoren : Added file: https://bugs.python.org/file47716/t.c ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34247] PYTHONOPTIMZE ignored in 3.7.0 when using custom launcher

New submission from Ronald Oussoren : Attached is a very basic launcher for python scripts. This script works as expected in Python 3.6, but not in 3.7.0. In particular, the launcher sets the environment variable PYTHONOPTIMIZE before calling Py_Initialize and that setting is ignored. I