[issue34282] Enum._convert shadows members named _convert

STINNER Victor added the comment: New changeset 19a1e1eb86115db66c1faae5927f87e3a12692fc by Victor Stinner (Zachary Ware) in branch 'master': bpo-34282: Remove deprecated enum _convert method (GH-13823) https://github.com/python/cpython/commit/19a1e1eb86115db66c1faae5927f87e3a12692fc

[issue34282] Enum._convert shadows members named _convert

Change by Zachary Ware : -- pull_requests: +13708 pull_request: https://github.com/python/cpython/pull/13823 ___ Python tracker ___

[issue34282] Enum._convert shadows members named _convert

Change by orlnub123 : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue34282] Enum._convert shadows members named _convert

Ethan Furman added the comment: New changeset 22e86fbbca04d251233fc07515885d2b67945094 by Ethan Furman (Miss Islington (bot)) in branch '3.6': [3.7] bpo-34282: Fix Enum._convert method shadowing members named _convert (GH-9034) (GH-9229)

[issue34282] Enum._convert shadows members named _convert

Change by miss-islington : -- pull_requests: +8660 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34282] Enum._convert shadows members named _convert

Ethan Furman added the comment: New changeset 0fb9fadd3b3e9e3698647e0b92d49b0b7aacd979 by Ethan Furman (orlnub123) in branch 'master': bpo-34282: Fix Enum._convert shadowing members named _convert (GH-8568) https://github.com/python/cpython/commit/0fb9fadd3b3e9e3698647e0b92d49b0b7aacd979

[issue34282] Enum._convert shadows members named _convert

Ethan Furman added the comment: New changeset c0d63bf73b35df374e6e66c08b0e297fb828d744 by Ethan Furman (orlnub123) in branch '3.7': [3.7] bpo-34282: Fix Enum._convert method shadowing members named _convert (GH-9034)

[issue34282] Enum._convert shadows members named _convert

Change by orlnub123 : -- pull_requests: +8496 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34282] Enum._convert shadows members named _convert

Ethan Furman added the comment: orlnub123 wrote: --- > In my testings _convert has always been available to them as they all > subclass Enum where it's defined. Wow, I really shouldn't check for things in the middle of the night. On the bright side, no further changes are needed

[issue34282] Enum._convert shadows members named _convert

orlnub123 added the comment: > Fixing bugs is often not backwards-compatible. ;) I think the number > of affected people here will be low, though, because anybody who had an > _convert member should have noticed that they couldn't use it. I think we had a misunderstanding, my proposal

[issue34282] Enum._convert shadows members named _convert

Ethan Furman added the comment: On 09/01/2018 01:21 AM, orlnub123 wrote: > On 08/31/2018 03:01 ethan.furman wrote: >> For versions 3.6 and 3.7 the solution is to modify the shadow check at >> line 236 so only DynamicClassAttributes are /not/ shadowed (meaning >> the _convert method would be

[issue34282] Enum._convert shadows members named _convert

orlnub123 added the comment: > For versions 3.6 and 3.7 the solution is to modify the shadow check at line > 236 so only DynamicClassAttributes are /not/ shadowed (meaning the _convert > method would be shadowed by an _convert member). Doing that might not be backwards-compatible. An enum

[issue34282] Enum._convert shadows members named _convert

Ethan Furman added the comment: For versions 3.6 and 3.7 the solution is to modify the shadow check at line 236 so only DynamicClassAttributes are /not/ shadowed (meaning the _convert method would be shadowed by an _convert member). For 3.8 we can move _convert to the metaclass: I wasn't

[issue34282] Enum._convert shadows members named _convert

Change by Ethan Furman : -- Removed message: https://bugs.python.org/msg324414 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue34282] Enum._convert shadows members named _convert

Ethan Furman added the comment: For versions 3.6 and 3.7 the solution is to modify the shadow check at line 236 so only DynamicClassAttributes are /not/ shadowed (meaning the _convert method would be shadowed by an _convert member). For 3.8 we can move _convert to the metaclass: I wasn't

[issue34282] Enum._convert shadows members named _convert

Change by Raymond Hettinger : -- assignee: -> ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34282] Enum._convert shadows members named _convert

New submission from orlnub123 : If an enum has a member named _convert it gets shadowed by the _convert method as shown below. >>> import enum >>> >>> class Test(enum.Enum): ... _convert = enum.auto() ... >>> Test._convert > I've came up with a couple of solutions: 1. Add _convert to

[issue34282] Enum._convert shadows members named _convert

Change by orlnub123 : -- keywords: +patch pull_requests: +8080 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list