[issue34588] traceback formatting can drop a frame

[miss-islington]

miss-islington  added the comment:


New changeset afb25bc2b5767ac3a83bc8c4d2826e8fdcb6b0e7 by Miss Islington (bot) 
in branch '3.6':
bpo-34588: Fix an off-by-one error in traceback formatting. (GH-9077)
https://github.com/python/cpython/commit/afb25bc2b5767ac3a83bc8c4d2826e8fdcb6b0e7


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34588] traceback formatting can drop a frame

[miss-islington]

miss-islington  added the comment:


New changeset 49020174305ca3dc90a811b03a05f44873297c61 by Miss Islington (bot) 
in branch '3.7':
bpo-34588: Fix an off-by-one error in traceback formatting. (GH-9077)
https://github.com/python/cpython/commit/49020174305ca3dc90a811b03a05f44873297c61


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34588] traceback formatting can drop a frame

[Benjamin Peterson]

Change by Benjamin Peterson :


--
nosy:  -miss-islington
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34588] traceback formatting can drop a frame

[miss-islington]

Change by miss-islington :


--
pull_requests: +8588

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34588] traceback formatting can drop a frame

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset d545869d084e70d4838310e79b52a25a72a1ca56 by Benjamin Peterson in 
branch 'master':
bpo-34588: Fix an off-by-one error in traceback formatting. (GH-9077)
https://github.com/python/cpython/commit/d545869d084e70d4838310e79b52a25a72a1ca56


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34588] traceback formatting can drop a frame

[miss-islington]

Change by miss-islington :


--
pull_requests: +8587

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34588] traceback formatting can drop a frame

[Benjamin Peterson]

Benjamin Peterson  added the comment:

It actually does save space because each traceback entry is usually two lines 
(frame id and source snippet).

I don't really have an opinion about what should happen be printed on the 
boundary cases. My current PR seems like a strict improvement to the current 
implementation, which is just incorrect.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34588] traceback formatting can drop a frame

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

In case of 4 repeated lines it doesn't make much sense to output 3 repeated 
lines and replace the forth line with "Previous line repeated 1 more time". 
This doesn't save space and doesn't help reading the traceback. I think it is 
better to output the forth repeated line.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34588] traceback formatting can drop a frame

[Benjamin Peterson]

Change by Benjamin Peterson :


--
keywords: +patch
pull_requests: +8535
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34588] traceback formatting can drop a frame

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Further investigation reveals this is a general off-by-one error with the 
recursive traceback pruning feature.

--
components: +Interpreter Core
title: traceback module can drop a frame -> traceback formatting can drop a 
frame

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com