[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by Andrew Svetlov : -- pull_requests: +15183, 15184 pull_request: https://github.com/python/cpython/pull/15492 ___ Python tracker ___

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by Andrew Svetlov : -- pull_requests: +15183, 15184, 15185 pull_request: https://github.com/python/cpython/pull/15492 ___ Python tracker ___

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by Andrew Svetlov : -- pull_requests: +15183 pull_request: https://github.com/python/cpython/pull/15492 ___ Python tracker ___

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by Andrew Svetlov : -- pull_requests: -15179 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by Andrew Svetlov : -- pull_requests: +15179 pull_request: https://github.com/python/cpython/pull/15492 ___ Python tracker ___

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker ___

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Yury Selivanov added the comment: I'll close this issue now. If you find another bug in how asyncio handles async generators please open a new one. Thanks! -- ___ Python tracker

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Yury Selivanov added the comment: New changeset a14dda5df62369d01db6c7519e73aae71d0e7cfe by Yury Selivanov (twisteroid ambassador) in branch '3.6': [3.6] bpo-34769: Thread safety for _asyncgen_finalizer_hook(). (GH-9716) (GH-9792)

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by twisteroid ambassador : -- pull_requests: +9174 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34769] _asyncgen_finalizer_hook running in wrong thread

miss-islington added the comment: New changeset 41e5ec377b36aa951ac095839d2f74f66ee1e665 by Miss Islington (bot) in branch '3.7': bpo-34769: Thread safety for _asyncgen_finalizer_hook(). (GH-9716) https://github.com/python/cpython/commit/41e5ec377b36aa951ac095839d2f74f66ee1e665 --

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by miss-islington : -- pull_requests: +9160 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by miss-islington : -- pull_requests: +9161 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Yury Selivanov added the comment: New changeset c880ffe7d2ce2fedb1831918c8a36e3623e0fb76 by Yury Selivanov (twisteroid ambassador) in branch 'master': bpo-34769: Thread safety for _asyncgen_finalizer_hook(). (GH-9716)

[issue34769] _asyncgen_finalizer_hook running in wrong thread

twisteroid ambassador added the comment: I’m now convinced that the bug we’re fixing and the original bug with debug mode off are two separate bugs. With the fix in place and debug mode off, I’m still seeing the original buggy behavior. Bummer. In my actual program, I have an async

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Change by twisteroid ambassador : -- keywords: +patch pull_requests: +9099 stage: -> patch review ___ Python tracker ___ ___

[issue34769] _asyncgen_finalizer_hook running in wrong thread

twisteroid ambassador added the comment: I'll open a PR with your diff soon, but I don't have a reliable unit test yet. Also, it does not seem to fix the old problem with debug mode off. :-( I had hoped that the problem with debug mode off is nothing more than _asyncgen_finalizer_hook not

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Yury Selivanov added the comment: Rereading your first message: > When testing my happy eyeballs library, I occasionally run into issues with > async generators seemingly not finalizing. After setting > loop.set_debug(True), I have been seeing log entries like these: The bug we are fixing

[issue34769] _asyncgen_finalizer_hook running in wrong thread

Yury Selivanov added the comment: Wow. Thanks so much for figuring this out, I know how hard it is to debug issues like this. Now I see it clearly: _asyncgen_finalizer_hook should be using loop.call_soon_threadsafe. Interestingly, I used _write_to_self there, so I knew about the issue,

[issue34769] _asyncgen_finalizer_hook running in wrong thread

twisteroid ambassador added the comment: I have finally managed to reproduce this one reliably. The issue happens when i) async generators are not finalized immediately and must be garbage collected in the future, and ii) the garbage collector happens to run in a different thread than the

[issue34769] _asyncgen_finalizer_hook running in wrong thread

New submission from twisteroid ambassador : When testing my happy eyeballs library, I occasionally run into issues with async generators seemingly not finalizing. After setting loop.set_debug(True), I have been seeing log entries like these: Exception ignored in: Traceback (most recent